Merge pull request #107 from gleanwork/cfreeman/fix-sdkconfiguration-genignore

chris-freeman-glean · web-flow · commit 18690c2cc2e4 · 2026-02-03T10:56:30.000-07:00
fix: make X-Glean hook resilient to SDK regeneration
diff --git a/src/glean/api_client/_hooks/x_glean.py b/src/glean/api_client/_hooks/x_glean.py
@@ -49,12 +49,12 @@ def before_request(
         # Get deprecated value - env var takes precedence
         deprecated_value = _get_first_value(
             os.environ.get("X_GLEAN_EXCLUDE_DEPRECATED_AFTER"),
-            hook_ctx.config.exclude_deprecated_after,
+            getattr(hook_ctx.config, "exclude_deprecated_after", None),
         )
 
         # Get experimental value - env var takes precedence
         config_experimental = (
-            "true" if hook_ctx.config.include_experimental is True else None
+            "true" if getattr(hook_ctx.config, "include_experimental", None) is True else None
         )
         experimental_value = _get_first_value(
             os.environ.get("X_GLEAN_INCLUDE_EXPERIMENTAL"),

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,12 @@ def before_request(`
`49`	`49`	`# Get deprecated value - env var takes precedence`
`50`	`50`	`deprecated_value = _get_first_value(`
`51`	`51`	`os.environ.get("X_GLEAN_EXCLUDE_DEPRECATED_AFTER"),`
`52`		`- hook_ctx.config.exclude_deprecated_after,`
	`52`	`+ getattr(hook_ctx.config, "exclude_deprecated_after", None),`
`53`	`53`	`)`
`54`	`54`
`55`	`55`	`# Get experimental value - env var takes precedence`
`56`	`56`	`config_experimental = (`
`57`		`- "true" if hook_ctx.config.include_experimental is True else None`
	`57`	`+ "true" if getattr(hook_ctx.config, "include_experimental", None) is True else None`
`58`	`58`	`)`
`59`	`59`	`experimental_value = _get_first_value(`
`60`	`60`	`os.environ.get("X_GLEAN_INCLUDE_EXPERIMENTAL"),`