Remove redundant move

Rafał Hibner · Rafał Hibner · commit d972d5b4fafd · 2025-07-04T09:07:12.000Z
diff --git a/cpp/src/arrow/util/vector.h b/cpp/src/arrow/util/vector.h
@@ -124,7 +124,7 @@ Result<std::vector<To>> MaybeMapVector(Fn&& map, std::vector<From>&& source) {
   ARROW_RETURN_NOT_OK(MaybeTransform(std::make_move_iterator(source.begin()),
                                      std::make_move_iterator(source.end()),
                                      std::back_inserter(out), std::forward<Fn>(map)));
-  return std::move(out);
+  return out;
 }
 
 template <typename T>

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ Result<std::vector<To>> MaybeMapVector(Fn&& map, std::vector<From>&& source) {`
`124`	`124`	`ARROW_RETURN_NOT_OK(MaybeTransform(std::make_move_iterator(source.begin()),`
`125`	`125`	`std::make_move_iterator(source.end()),`
`126`	`126`	`std::back_inserter(out), std::forward<Fn>(map)));`
`127`		`- return std::move(out);`
	`127`	`+ return out;`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`template <typename T>`