Skip to content

Commit 4a555a9

Browse files
Copilotd10c
andcommitted
Fix remaining type errors for CI build
- Fixed MethodRow forwardRef types to use HTMLDivElement instead of HTMLElement | undefined - Fixed MethodRow ref in useRef to use HTMLDivElement with null instead of HTMLElement | undefined - Removed unused ChangeEvent imports from ModelTypeTextbox and RepoRow This resolves all TypeScript compilation errors in the CI. Co-authored-by: d10c <9970661+d10c@users.noreply.github.com>
1 parent 628f711 commit 4a555a9

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export type MethodRowProps = {
8585
export const MethodRow = (props: MethodRowProps) => {
8686
const { method, methodCanBeModeled, revealedMethodSignature } = props;
8787

88-
const ref = useRef<HTMLElement | undefined>(undefined);
88+
const ref = useRef<HTMLDivElement>(null);
8989

9090
useEffect(() => {
9191
if (method.signature === revealedMethodSignature) {
@@ -103,7 +103,7 @@ export const MethodRow = (props: MethodRowProps) => {
103103
}
104104
};
105105

106-
const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
106+
const ModelableMethodRow = forwardRef<HTMLDivElement, MethodRowProps>(
107107
(props: MethodRowProps, ref) => {
108108
const {
109109
method,
@@ -360,7 +360,7 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
360360
ModelableMethodRow.displayName = "ModelableMethodRow";
361361

362362
const UnmodelableMethodRow = forwardRef<
363-
HTMLElement | undefined,
363+
HTMLDivElement,
364364
MethodRowProps
365365
>((props: MethodRowProps, ref) => {
366366
const { method, viewState, revealedMethodSignature } = props;

extensions/ql-vscode/src/view/model-editor/ModelTypeTextbox.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import type { ChangeEvent } from "react";
21
import { useCallback, useEffect, useState } from "react";
32
import type {
43
ModeledMethod,

extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import type { ChangeEvent } from "react";
21
import { useCallback, useEffect, useState } from "react";
32
import { styled } from "styled-components";
43
import { VscodeCheckbox } from "@vscode-elements/react-elements";

0 commit comments

Comments
 (0)