fix: review comments

Author: dhilipkumars

CHANGELOG.md

@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- **Agent Skills Installation**: New `--agent-skills` CLI option to install Prompt.MD templates as agent skills following [agentskills.io specification](https://agentskills.io/specification)
+- **Agent Skills Installation**: New `--ai-skills` CLI option to install Prompt.MD templates as agent skills following [agentskills.io specification](https://agentskills.io/specification)
   - Skills are installed to `.agent/skills/<skill-name>/SKILL.md` directory structure
   - Requires `--ai` flag to be specified
   - Converts all 9 spec-kit command templates (specify, plan, tasks, implement, analyze, clarify, constitution, checklist, taskstoissues) to properly formatted SKILL.md files

README.md

@@ -189,7 +189,7 @@ The `specify` command supports the following options:
 | `--debug`              | Flag     | Enable detailed debug output for troubleshooting                                                                                                                                             |
 | `--github-token`       | Option   | GitHub token for API requests (or set GH_TOKEN/GITHUB_TOKEN env variable)                                                                                                                    |
 
-| `--agent-skills`       | Flag     | Install Prompt.MD templates as agent skills in `.agent/skills/` directory (requires `--ai`)                                                                                                  |
+| `--ai-skills`       | Flag     | Install Prompt.MD templates as agent skills in `.agent/skills/` directory (requires `--ai`)                                                                                                  |
 ### Examples
 
 ```bash
@@ -240,10 +240,10 @@ specify init my-project --ai claude --debug
 specify init my-project --ai claude --github-token ghp_your_token_here
 
 # Install agent skills with the project
-specify init my-project --ai claude --agent-skills
+specify init my-project --ai claude --ai-skills
 
 # Initialize in current directory with agent skills
-specify init --here --ai gemini --agent-skills
+specify init --here --ai gemini --ai-skills
 
 # Check system requirements
 specify check

src/specify_cli/__init__.py

@@ -944,7 +944,7 @@ def ensure_executable_scripts(project_path: Path, tracker: StepTracker | None =
                 console.print(f"  - {f}")
 
 
-def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> bool:
+def install_ai_skills(project_path: Path, tracker: StepTracker = None) -> bool:
     """
     Install Prompt.MD files from templates/commands/ as agent skills per agentskills.io spec.
     
@@ -962,7 +962,7 @@ def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> boo
 
     if not templates_dir.exists():
         if tracker:
-            tracker.error("agent-skills", "templates/commands not found")
+            tracker.error("ai-skills", "templates/commands not found")
         else:
             console.print("[yellow]Warning: templates/commands directory not found, skipping skills installation[/yellow]")
         return False
@@ -971,7 +971,7 @@ def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> boo
     command_files = list(templates_dir.glob("*.md"))
     if not command_files:
         if tracker:
-            tracker.skip("agent-skills", "no command templates found")
+            tracker.skip("ai-skills", "no command templates found")
         else:
             console.print("[yellow]No command templates found to install[/yellow]")
         return False
@@ -981,8 +981,8 @@ def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> boo
     skills_dir.mkdir(parents=True, exist_ok=True)
 
     if tracker:
-        tracker.add("agent-skills", f"Install {len(command_files)} agent skills")
-        tracker.start("agent-skills")
+        tracker.add("ai-skills", f"Install {len(command_files)} agent skills")
+        tracker.start("ai-skills")
 
     installed_count = 0
     for command_file in command_files:
@@ -1039,7 +1039,7 @@ def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> boo
             skill_content = f"""---
 name: {skill_name}
 description: {enhanced_desc}
-compatibility: Requires git and spec-kit project structure with .specify/ directory
+compatibility: Requires git and spec-kit project structure with .agent/skills/ directory
 ---
 
 # Speckit {command_name.title()} Skill
@@ -1055,14 +1055,14 @@ def install_agent_skills(project_path: Path, tracker: StepTracker = None) -> boo
             installed_count += 1
 
         except Exception as e:
-            console.print(f"[yellow]Warning: Failed to install skill {command_name}: {e}[/yellow]")
+            console.print(f"[yellow]Warning: Failed to install skill {command_file.stem}: {e}[/yellow]")
             continue
 
     if tracker:
         if installed_count > 0:
-            tracker.complete("agent-skills", f"{installed_count} skills installed")
+            tracker.complete("ai-skills", f"{installed_count} skills installed")
         else:
-            tracker.error("agent-skills", "no skills installed")
+            tracker.error("ai-skills", "no skills installed")
     else:
         if installed_count > 0:
             console.print(f"[green]✓[/green] Installed {installed_count} agent skills to .agent/skills/")
@@ -1083,7 +1083,7 @@ def init(
     skip_tls: bool = typer.Option(False, "--skip-tls", help="Skip SSL/TLS verification (not recommended)"),
     debug: bool = typer.Option(False, "--debug", help="Show verbose diagnostic output for network and extraction failures"),
     github_token: str = typer.Option(None, "--github-token", help="GitHub token to use for API requests (or set GH_TOKEN or GITHUB_TOKEN environment variable)"),
-    agent_skills: bool = typer.Option(False, "--agent-skills", help="Install Prompt.MD templates as agent skills (requires --ai)"),
+    ai_skills: bool = typer.Option(False, "--ai-skills", help="Install Prompt.MD templates as agent skills (requires --ai)"),
 ):
     """
     Initialize a new Specify project from the latest template.
@@ -1124,10 +1124,10 @@ def init(
         console.print("[red]Error:[/red] Must specify either a project name, use '.' for current directory, or use --here flag")
         raise typer.Exit(1)
 
-    # Validate --agent-skills requires --ai
-    if agent_skills and not ai_assistant:
-        console.print("[red]Error:[/red] --agent-skills requires --ai to be specified")
-        console.print("[yellow]Usage:[/yellow] specify init <project> --ai <agent> --agent-skills")
+    # Validate --ai-skills requires --ai
+    if ai_skills and not ai_assistant:
+        console.print("[red]Error:[/red] --ai-skills requires --ai to be specified")
+        console.print("[yellow]Usage:[/yellow] specify init <project> --ai <agent> --ai-skills")
         raise typer.Exit(1)
 
 
@@ -1266,8 +1266,8 @@ def init(
             ensure_executable_scripts(project_path, tracker=tracker)
 
             # Install agent skills if requested
-            if agent_skills:
-                install_agent_skills(project_path, tracker=tracker)
+            if ai_skills:
+                install_ai_skills(project_path, tracker=tracker)
 
             if not no_git:
                 tracker.start("git")