clean up and fix tests

Author: kerobbi

pkg/github/dependencies.go

@@ -262,7 +262,6 @@ func NewRequestDeps(
 	lockdownMode bool,
 	repoAccessOpts []lockdown.RepoAccessOption,
 	t translations.TranslationHelperFunc,
-	flags FeatureFlags,
 	contentWindowSize int,
 	featureChecker inventory.FeatureFlagChecker,
 ) *RequestDeps {
@@ -272,7 +271,6 @@ func NewRequestDeps(
 		lockdownMode:      lockdownMode,
 		RepoAccessOpts:    repoAccessOpts,
 		T:                 t,
-		Flags:             flags,
 		ContentWindowSize: contentWindowSize,
 		featureChecker:    featureChecker,
 	}

pkg/github/server_test.go

@@ -56,7 +56,7 @@ func (s stubDeps) GetRepoAccessCache(ctx context.Context) (*lockdown.RepoAccessC
 	return s.repoAccessCache, nil
 }
 func (s stubDeps) GetT() translations.TranslationHelperFunc          { return s.t }
-func (s stubDeps) GetFlags() FeatureFlags                            { return s.flags }
+func (s stubDeps) GetFlags(ctx context.Context) FeatureFlags         { return s.flags }
 func (s stubDeps) GetContentWindowSize() int                         { return s.contentWindowSize }
 func (s stubDeps) IsFeatureEnabled(_ context.Context, _ string) bool { return false }
 

pkg/http/server.go

@@ -89,9 +89,6 @@ func RunHTTPServer(cfg HTTPServerConfig) error {
 		cfg.LockdownMode,
 		repoAccessOpts,
 		t,
-		github.FeatureFlags{
-			LockdownMode: cfg.LockdownMode,
-		},
 		cfg.ContentWindowSize,
 		nil,
 	)