Fix linter issues

Author: omgitsads

cmd/github-mcp-server/main.go

@@ -97,7 +97,7 @@ var (
 		Long:  `Start an HTTP server that listens for MCP requests over HTTP.`,
 		RunE: func(_ *cobra.Command, _ []string) error {
 			ttl := viper.GetDuration("repo-access-cache-ttl")
-			httpConfig := ghhttp.HTTPServerConfig{
+			httpConfig := ghhttp.ServerConfig{
 				Version:              version,
 				Host:                 viper.GetString("host"),
 				Port:                 viper.GetInt("port"),

pkg/github/server_test.go

@@ -52,11 +52,11 @@ func (s stubDeps) GetRawClient(ctx context.Context) (*raw.Client, error) {
 	return nil, nil
 }
 
-func (s stubDeps) GetRepoAccessCache(ctx context.Context) (*lockdown.RepoAccessCache, error) {
+func (s stubDeps) GetRepoAccessCache(_ context.Context) (*lockdown.RepoAccessCache, error) {
 	return s.repoAccessCache, nil
 }
 func (s stubDeps) GetT() translations.TranslationHelperFunc          { return s.t }
-func (s stubDeps) GetFlags(ctx context.Context) FeatureFlags         { return s.flags }
+func (s stubDeps) GetFlags(_ context.Context) FeatureFlags           { return s.flags }
 func (s stubDeps) GetContentWindowSize() int                         { return s.contentWindowSize }
 func (s stubDeps) IsFeatureEnabled(_ context.Context, _ string) bool { return false }
 

pkg/http/handler.go

@@ -18,43 +18,43 @@ import (
 type InventoryFactoryFunc func(r *http.Request) (*inventory.Inventory, error)
 type GitHubMCPServerFactoryFunc func(r *http.Request, deps github.ToolDependencies, inventory *inventory.Inventory, cfg *github.MCPServerConfig) (*mcp.Server, error)
 
-type HTTPMcpHandler struct {
+type Handler struct {
 	ctx                    context.Context
-	config                 *HTTPServerConfig
+	config                 *ServerConfig
 	deps                   github.ToolDependencies
 	logger                 *slog.Logger
 	t                      translations.TranslationHelperFunc
 	githubMcpServerFactory GitHubMCPServerFactoryFunc
 	inventoryFactoryFunc   InventoryFactoryFunc
 }
 
-type HTTPMcpHandlerOptions struct {
+type HandlerOptions struct {
 	GitHubMcpServerFactory GitHubMCPServerFactoryFunc
 	InventoryFactory       InventoryFactoryFunc
 }
 
-type HTTPMcpHandlerOption func(*HTTPMcpHandlerOptions)
+type HandlerOption func(*HandlerOptions)
 
-func WithGitHubMCPServerFactory(f GitHubMCPServerFactoryFunc) HTTPMcpHandlerOption {
-	return func(o *HTTPMcpHandlerOptions) {
+func WithGitHubMCPServerFactory(f GitHubMCPServerFactoryFunc) HandlerOption {
+	return func(o *HandlerOptions) {
 		o.GitHubMcpServerFactory = f
 	}
 }
 
-func WithInventoryFactory(f InventoryFactoryFunc) HTTPMcpHandlerOption {
-	return func(o *HTTPMcpHandlerOptions) {
+func WithInventoryFactory(f InventoryFactoryFunc) HandlerOption {
+	return func(o *HandlerOptions) {
 		o.InventoryFactory = f
 	}
 }
 
 func NewHTTPMcpHandler(
 	ctx context.Context,
-	cfg *HTTPServerConfig,
+	cfg *ServerConfig,
 	deps github.ToolDependencies,
 	t translations.TranslationHelperFunc,
 	logger *slog.Logger,
-	options ...HTTPMcpHandlerOption) *HTTPMcpHandler {
-	opts := &HTTPMcpHandlerOptions{}
+	options ...HandlerOption) *Handler {
+	opts := &HandlerOptions{}
 	for _, o := range options {
 		o(opts)
 	}
@@ -69,7 +69,7 @@ func NewHTTPMcpHandler(
 		inventoryFactory = DefaultInventoryFactory(cfg, t, nil)
 	}
 
-	return &HTTPMcpHandler{
+	return &Handler{
 		ctx:                    ctx,
 		config:                 cfg,
 		deps:                   deps,
@@ -82,7 +82,7 @@ func NewHTTPMcpHandler(
 
 // RegisterRoutes registers the routes for the MCP server
 // URL-based values take precedence over header-based values
-func (h *HTTPMcpHandler) RegisterRoutes(r chi.Router) {
+func (h *Handler) RegisterRoutes(r chi.Router) {
 	r.Use(middleware.WithRequestConfig)
 
 	r.Mount("/", h)
@@ -109,7 +109,7 @@ func withToolset(next http.Handler) http.Handler {
 	})
 }
 
-func (h *HTTPMcpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	inventory, err := h.inventoryFactoryFunc(r)
 	if err != nil {
 		w.WriteHeader(http.StatusInternalServerError)
@@ -128,7 +128,7 @@ func (h *HTTPMcpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusInternalServerError)
 	}
 
-	mcpHandler := mcp.NewStreamableHTTPHandler(func(r *http.Request) *mcp.Server {
+	mcpHandler := mcp.NewStreamableHTTPHandler(func(_ *http.Request) *mcp.Server {
 		return ghServer
 	}, &mcp.StreamableHTTPOptions{
 		Stateless: true,
@@ -141,7 +141,7 @@ func DefaultGitHubMCPServerFactory(r *http.Request, deps github.ToolDependencies
 	return github.NewMCPServer(r.Context(), cfg, deps, inventory)
 }
 
-func DefaultInventoryFactory(cfg *HTTPServerConfig, t translations.TranslationHelperFunc, staticChecker inventory.FeatureFlagChecker) InventoryFactoryFunc {
+func DefaultInventoryFactory(_ *ServerConfig, t translations.TranslationHelperFunc, staticChecker inventory.FeatureFlagChecker) InventoryFactoryFunc {
 	return func(r *http.Request) (*inventory.Inventory, error) {
 		b := github.NewInventory(t).WithDeprecatedAliases(github.DeprecatedToolAliases)
 

pkg/http/handler_test.go

@@ -252,7 +252,7 @@ func TestHTTPHandlerRoutes(t *testing.T) {
 			// Create handler with our factories
 			handler := NewHTTPMcpHandler(
 				context.Background(),
-				&HTTPServerConfig{Version: "test"},
+				&ServerConfig{Version: "test"},
 				nil, // deps not needed for this test
 				translations.NullTranslationHelper,
 				slog.Default(),

pkg/http/middleware/token.go

@@ -24,7 +24,6 @@ var (
 	errMissingAuthorizationHeader     = fmt.Errorf("%w: missing required Authorization header", mark.ErrBadRequest)
 	errBadAuthorizationHeader         = fmt.Errorf("%w: Authorization header is badly formatted", mark.ErrBadRequest)
 	errUnsupportedAuthorizationHeader = fmt.Errorf("%w: unsupported Authorization header", mark.ErrBadRequest)
-	errMissingTokenInfoHeader         = fmt.Errorf("%w: missing required token info header", mark.ErrBadRequest)
 )
 
 var supportedThirdPartyTokenPrefixes = []string{

pkg/http/server.go

@@ -18,7 +18,7 @@ import (
 	"github.com/go-chi/chi/v5"
 )
 
-type HTTPServerConfig struct {
+type ServerConfig struct {
 	// Version of the server
 	Version string
 
@@ -48,7 +48,7 @@ type HTTPServerConfig struct {
 	RepoAccessCacheTTL *time.Duration
 }
 
-func RunHTTPServer(cfg HTTPServerConfig) error {
+func RunHTTPServer(cfg ServerConfig) error {
 	// Create app context
 	ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
 	defer stop()