Skip to content

Commit a443896

Browse files
committed
Dont automatically enable IFCLabels in insiders mode
1 parent 6012e53 commit a443896

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

pkg/github/feature_flags.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ var AllowedFeatureFlags = []string{
3636
var InsidersFeatureFlags = []string{
3737
MCPAppsFeatureFlag,
3838
FeatureFlagCSVOutput,
39-
FeatureFlagIFCLabels,
4039
FeatureFlagIssueFields,
4140
}
4241

pkg/github/feature_flags_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,10 @@ func TestResolveFeatureFlags(t *testing.T) {
162162
expectedFlags: InsidersFeatureFlags,
163163
},
164164
{
165-
name: "insiders mode enables internal-only flags",
165+
name: "insiders mode does not auto-enable ifc labels",
166166
enabledFeatures: nil,
167167
insidersMode: true,
168-
expectedFlags: []string{FeatureFlagIFCLabels},
168+
unexpectedFlags: []string{FeatureFlagIFCLabels},
169169
},
170170
{
171171
name: "ifc_labels can be directly enabled",

pkg/http/server_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ func TestCreateHTTPFeatureChecker(t *testing.T) {
9494
wantEnabled: true,
9595
},
9696
{
97-
name: "insiders mode enables internal-only insiders flags",
97+
name: "insiders mode does not auto-enable ifc labels",
9898
flagName: github.FeatureFlagIFCLabels,
9999
insidersMode: true,
100-
wantEnabled: true,
100+
wantEnabled: false,
101101
},
102102
{
103103
name: "insiders mode does not enable granular flags",

0 commit comments

Comments
 (0)