Remove memoized initialization from RequestDeps.

Author: omgitsads

pkg/github/dependencies.go

@@ -237,11 +237,6 @@ func NewToolFromHandler(
 }
 
 type RequestDeps struct {
-	Client          *gogithub.Client
-	GQLClient       *githubv4.Client
-	RawClient       *raw.Client
-	RepoAccessCache *lockdown.RepoAccessCache
-
 	// Static dependencies
 	apiHosts          utils.APIHostResolver
 	version           string
@@ -277,10 +272,6 @@ func NewRequestDeps(
 
 // GetClient implements ToolDependencies.
 func (d *RequestDeps) GetClient(ctx context.Context) (*gogithub.Client, error) {
-	if d.Client != nil {
-		return d.Client, nil
-	}
-
 	// extract the token from the context
 	tokenInfo, ok := ghcontext.GetTokenInfo(ctx)
 	if !ok {
@@ -307,10 +298,6 @@ func (d *RequestDeps) GetClient(ctx context.Context) (*gogithub.Client, error) {
 
 // GetGQLClient implements ToolDependencies.
 func (d *RequestDeps) GetGQLClient(ctx context.Context) (*githubv4.Client, error) {
-	if d.GQLClient != nil {
-		return d.GQLClient, nil
-	}
-
 	// extract the token from the context
 	tokenInfo, ok := ghcontext.GetTokenInfo(ctx)
 	if !ok {
@@ -337,16 +324,11 @@ func (d *RequestDeps) GetGQLClient(ctx context.Context) (*githubv4.Client, error
 	}
 
 	gqlClient := githubv4.NewEnterpriseClient(graphqlURL.String(), gqlHTTPClient)
-	d.GQLClient = gqlClient
 	return gqlClient, nil
 }
 
 // GetRawClient implements ToolDependencies.
 func (d *RequestDeps) GetRawClient(ctx context.Context) (*raw.Client, error) {
-	if d.RawClient != nil {
-		return d.RawClient, nil
-	}
-
 	client, err := d.GetClient(ctx)
 	if err != nil {
 		return nil, err
@@ -358,7 +340,6 @@ func (d *RequestDeps) GetRawClient(ctx context.Context) (*raw.Client, error) {
 	}
 
 	rawClient := raw.NewClient(client, rawURL)
-	d.RawClient = rawClient
 
 	return rawClient, nil
 }
@@ -369,18 +350,13 @@ func (d *RequestDeps) GetRepoAccessCache(ctx context.Context) (*lockdown.RepoAcc
 		return nil, nil
 	}
 
-	if d.RepoAccessCache != nil {
-		return d.RepoAccessCache, nil
-	}
-
 	gqlClient, err := d.GetGQLClient(ctx)
 	if err != nil {
 		return nil, err
 	}
 
 	// Create repo access cache
 	instance := lockdown.GetInstance(gqlClient, d.RepoAccessOpts...)
-	d.RepoAccessCache = instance
 	return instance, nil
 }