Commit 74cad77
committed
Restore Optional public API from #187 and add missing @JsonInclude annotations
Revert commit 8e0eeeb which accidentally rolled back all Optional usage
from PR #189. Restore Optional<Boolean>, OptionalInt, and OptionalDouble
return types on public config getters, primitive setters, and clearXxx()
methods. Additionally, add @JsonInclude(NON_NULL) and @JsonProperty
annotations to classes that were missing them.
--- Per-file changes ---
src/main/java/com/github/copilot/sdk/json/CopilotClientOptions.java:
Restore Optional<Boolean> for getUseLoggedInUser(), OptionalInt for
getSessionIdleTimeoutSeconds(). Restore primitive setters and
clearXxx() methods. Re-add @JsonIgnore on Optional-returning getters.
src/main/java/com/github/copilot/sdk/json/SessionConfig.java:
Restore Optional<Boolean> for getEnableSessionTelemetry(),
getEnableConfigDiscovery(), getIncludeSubAgentStreamingEvents().
Restore primitive setters and clearXxx() methods. Re-add @JsonIgnore.
src/main/java/com/github/copilot/sdk/json/ResumeSessionConfig.java:
Same Optional pattern restored for getEnableSessionTelemetry(),
getEnableConfigDiscovery(), getIncludeSubAgentStreamingEvents().
src/main/java/com/github/copilot/sdk/json/InfiniteSessionConfig.java:
Restore Optional<Boolean> for getEnabled(), OptionalDouble for
getBackgroundCompactionThreshold() and getBufferExhaustionThreshold().
src/main/java/com/github/copilot/sdk/json/InputOptions.java:
Restore OptionalInt for getMinLength() and getMaxLength(). Add
@JsonInclude(NON_NULL) to class. Add @JsonProperty on minLength and
maxLength fields to ensure Jackson serialization works with
@JsonIgnore on the OptionalInt getters.
src/main/java/com/github/copilot/sdk/json/ModelCapabilitiesOverride.java:
Restore Optional<Boolean> for Supports.getVision() and
Supports.getReasoningEffort(). Restore OptionalInt for
Limits.getMaxPromptTokens(), getMaxOutputTokens(),
getMaxContextWindowTokens(). Restore clearXxx() methods.
src/main/java/com/github/copilot/sdk/json/ProviderConfig.java:
Restore OptionalInt for getMaxPromptTokens() and getMaxOutputTokens().
src/main/java/com/github/copilot/sdk/json/TelemetryConfig.java:
Restore Optional<Boolean> for getCaptureContent(). Add
@JsonInclude(NON_NULL) to class.
src/main/java/com/github/copilot/sdk/json/SessionUiCapabilities.java:
Restore Optional<Boolean> for getElicitation(). Add
@JsonInclude(NON_NULL) to class.
src/main/java/com/github/copilot/sdk/json/CustomAgentConfig.java:
Restore Optional<Boolean> for getInfer().
src/main/java/com/github/copilot/sdk/json/UserInputRequest.java:
Restore Optional<Boolean> for getAllowFreeform(). Add
@JsonInclude(NON_NULL) to class.
src/main/java/com/github/copilot/sdk/json/CreateSessionRequest.java:
Restore primitive boolean setters and clearXxx() methods for wire DTO
flags (enableSessionTelemetry, requestPermission, requestUserInput,
hooks, streaming, enableConfigDiscovery, includeSubAgentStreamingEvents,
requestElicitation).
src/main/java/com/github/copilot/sdk/json/ResumeSessionRequest.java:
Same primitive setter and clearXxx() restoration as CreateSessionRequest.
src/main/java/com/github/copilot/sdk/CliServerManager.java:
Update callers to use Optional APIs (.orElse(), .isPresent(),
.getAsInt()) instead of null checks.
src/main/java/com/github/copilot/sdk/CopilotClient.java:
Update useLoggedInUser check to use .isPresent() instead of != null.
src/main/java/com/github/copilot/sdk/CopilotSession.java:
Update assertElicitation() to use .orElse(false). Update input()
method to use .isPresent()/.getAsInt() for minLength/maxLength.
Update setModel() to use .orElse(null) for vision/reasoningEffort.
src/main/java/com/github/copilot/sdk/SessionRequestBuilder.java:
Update buildCreateRequest() and buildResumeRequest() to use
.ifPresent() for enableSessionTelemetry, enableConfigDiscovery,
includeSubAgentStreamingEvents. Restore conditional-set patterns
for requestUserInput, hooks, streaming, disableResume.
src/test/java/com/github/copilot/sdk/OptionalApiAndJacksonTest.java:
Restore comprehensive test class with clearXxx() tests for all 12
public config classes and Jackson serialization roundtrip tests.
src/test/java/com/github/copilot/sdk/JsonIncludeNonNullTest.java:
New test class verifying @JsonInclude(NON_NULL) annotation presence
on 11 DTO classes and serialization behavior (null fields omitted,
set fields included) for InputOptions, TelemetryConfig,
SessionUiCapabilities, and UserInputRequest.
src/test/java/com/github/copilot/sdk/ConfigCloneTest.java:
Update assertions to use Optional APIs (.orElse(), .isEmpty()).
src/test/java/com/github/copilot/sdk/CopilotClientTest.java:
Update assertions to use Optional APIs (.isEmpty(), Optional.of()).
src/test/java/com/github/copilot/sdk/DataObjectCoverageTest.java:
Update assertions to use Optional APIs (.orElse(), .getAsInt()).
src/test/java/com/github/copilot/sdk/ElicitationTest.java:
Update assertions to use Optional APIs (.get(), .getAsInt()).
src/test/java/com/github/copilot/sdk/ProviderConfigTest.java:
Update assertions to use OptionalInt APIs (.getAsInt(), .isEmpty()).
src/test/java/com/github/copilot/sdk/TelemetryConfigTest.java:
Update assertions to use Optional APIs (.get(), .isEmpty()).1 parent a04ea0b commit 74cad77
5 files changed
Lines changed: 170 additions & 0 deletions
File tree
- src
- main/java/com/github/copilot/sdk/json
- test/java/com/github/copilot/sdk
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| 23 | + | |
20 | 24 | | |
| 25 | + | |
21 | 26 | | |
22 | 27 | | |
23 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 159 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
0 commit comments