From b91a2cc1594c7a69d1d18a11c00c4f7d825b8342 Mon Sep 17 00:00:00 2001 From: Mathias Vorreiter Pedersen Date: Mon, 28 Apr 2025 17:36:37 +0100 Subject: [PATCH] Shared: Use 'isSink/1' in 'PropagateFlowConfig'. --- .../mad/modelgenerator/internal/ModelGeneratorImpl.qll | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll b/shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll index 27521b31d00b..b9592964f931 100644 --- a/shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll +++ b/shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll @@ -484,10 +484,14 @@ module MakeModelGenerator< } predicate isSink(DataFlow::Node sink, FlowState state) { + // Sinks are provided by `isSink/1` + none() + } + + predicate isSink(DataFlow::Node sink) { sink instanceof ReturnNodeExt and not isOwnInstanceAccessNode(sink) and - not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink))) and - (state instanceof TaintRead or state instanceof TaintStore) + not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink))) } predicate isAdditionalFlowStep(