From 2d6457e4d36d58531815fd674a8792c0b22678b5 Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Mon, 28 Apr 2025 11:45:12 +0200 Subject: [PATCH 1/4] C#: Set the precision of cs/equality-on-floats to high. --- csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql b/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql index bdf3ee4e97c8..1109201fbe19 100644 --- a/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql +++ b/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql @@ -5,7 +5,7 @@ * computation does not follow the standard rules of algebra. * @kind problem * @problem.severity warning - * @precision medium + * @precision high * @id cs/equality-on-floats * @tags reliability * correctness From 318bfc6d7386f19b9e6692ef3b48ff9b8cf258eb Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Mon, 28 Apr 2025 13:32:34 +0200 Subject: [PATCH 2/4] C#: Add cs/equality-on-floats to the code-quality suite. --- csharp/ql/src/codeql-suites/csharp-code-quality.qls | 1 + 1 file changed, 1 insertion(+) diff --git a/csharp/ql/src/codeql-suites/csharp-code-quality.qls b/csharp/ql/src/codeql-suites/csharp-code-quality.qls index 64a100acda22..85bbe4db683d 100644 --- a/csharp/ql/src/codeql-suites/csharp-code-quality.qls +++ b/csharp/ql/src/codeql-suites/csharp-code-quality.qls @@ -14,3 +14,4 @@ - cs/non-short-circuit - cs/useless-assignment-to-local - cs/invalid-string-formatting + - cs/equality-on-floats From 8bc965641ae488a2175b2364f3c5c41d5f0ab502 Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Mon, 28 Apr 2025 13:38:15 +0200 Subject: [PATCH 3/4] C#: Update integration tests expected output. --- .../posix/query-suite/csharp-code-quality.qls.expected | 1 + 1 file changed, 1 insertion(+) diff --git a/csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected b/csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected index 472e79575ca5..dc3791621c3e 100644 --- a/csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected +++ b/csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected @@ -5,6 +5,7 @@ ql/csharp/ql/src/Dead Code/DeadStoreOfLocal.ql ql/csharp/ql/src/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql ql/csharp/ql/src/Likely Bugs/Collections/ContainerSizeCmpZero.ql ql/csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.ql +ql/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql ql/csharp/ql/src/Likely Bugs/ReferenceEqualsOnValueTypes.ql ql/csharp/ql/src/Likely Bugs/SelfAssignment.ql ql/csharp/ql/src/Likely Bugs/UncheckedCastInEquals.ql From f9d8be1ef75a9eb38cf57c9047ef1af1562e8087 Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Mon, 28 Apr 2025 13:41:06 +0200 Subject: [PATCH 4/4] C#: Add change note. --- .../change-notes/2025-04-28-equality-on-floats-precision.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 csharp/ql/src/change-notes/2025-04-28-equality-on-floats-precision.md diff --git a/csharp/ql/src/change-notes/2025-04-28-equality-on-floats-precision.md b/csharp/ql/src/change-notes/2025-04-28-equality-on-floats-precision.md new file mode 100644 index 000000000000..a990d236eecb --- /dev/null +++ b/csharp/ql/src/change-notes/2025-04-28-equality-on-floats-precision.md @@ -0,0 +1,4 @@ +--- +category: minorAnalysis +--- +* Changed the precision of the `cs/equality-on-floats` query from medium to high.