wip

Author: asgerf

javascript/ql/lib/semmle/javascript/internal/NameResolution.qll

@@ -250,6 +250,17 @@ module NameResolution {
     )
   }
 
+  /**
+   * A step that treats imports of form `import foo from "somewhere"` as a namespace import,
+   * to support some non-standard compilers.
+   */
+  private predicate defaultImportInteropStep(Node node1, Node node2) {
+    exists(ImportDefaultSpecifier spec |
+      node1 = spec.getImportDeclaration().getImportedPathExpr() and
+      node2 = spec.getLocal()
+    )
+  }
+
   private signature module TypeResolutionInputSig {
     /**
      * Holds if flow is permitted through the given variable.
@@ -488,7 +499,14 @@ module NameResolution {
   /**
    * Gets a node to which the given module flows.
    */
-  predicate trackModule = ValueFlow::TrackNode<ModuleLike>::track/1;
+  Node trackModule(ModuleLike mod) {
+    result = mod
+    or
+    ValueFlow::step(trackModule(mod), result)
+    or
+    defaultImportInteropStep(trackModule(mod), result) and
+    not mod.(ES2015Module).hasBothNamedAndDefaultExports()
+  }
 
   predicate trackClassValue = ValueFlow::TrackNode<ClassDefinition>::track/1;
 

javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected

@@ -1,4 +1,13 @@
 testFailures
+| pack3/lib.js:1:16:1:33 |  | Unexpected result: name=(pack3).libFunction.default |
+| pack3/lib.js:1:35:1:118 | // $ na ... unction | Missing result: alias=(pack3).libFunction.default==(pack3).libFunction |
+| pack3/lib.js:1:35:1:118 | // $ na ... unction | Missing result: name=(pack3).libFunction |
+| pack8/foo.js:1:1:1:12 |  | Unexpected result: name=(pack8).Foo.Foo |
+| pack8/foo.js:1:14:1:34 | // $ na ... k8).Foo | Missing result: name=(pack8).Foo |
+| pack8/foo.js:4:26:4:28 |  | Unexpected result: alias=(pack8).Foo.default==(pack8).Foo.Foo |
+| pack8/foo.js:4:31:4:73 | // $ al ... k8).Foo | Missing result: alias=(pack8).Foo.default==(pack8).Foo |
+| pack8/foo.js:5:27:5:65 | // $ al ... k8).Foo | Missing result: alias=(pack8).Foo.Foo==(pack8).Foo |
+| pack10/foo.js:1:34:1:55 | // $ na ... 10).Foo | Missing result: name=(pack10).Foo |
 ambiguousPreferredPredecessor
 | pack2/lib.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getInstance() |
 | pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") |