Skip to content

Commit fb6b6c3

Browse files
committed
JS: Accept "regressions" in UnneededDefensiveCode
One of the expectations I removed as we definitely don't want to flag that.
1 parent af17ada commit fb6b6c3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/global-module-definition.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ var Mod1;
77
var Mod2;
88
(function (Mod2) {
99
Mod2.p = 42;
10-
})(Mod2 || (Mod2 = {})); // $ Alert
10+
})(Mod2 || (Mod2 = {}));
1111
});

javascript/ql/test/query-tests/Expressions/UnneededDefensiveProgramming/tst.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
var o_ = o;
1111
var x_ = x;
1212

13-
u_ = u_ || e; // $ Alert
14-
n_ = n_ || e; // $ Alert
15-
o_ = o_ || e; // $ Alert
13+
u_ = u_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
14+
n_ = n_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
15+
o_ = o_ || e; // $ MISSING: Alert[js/unneeded-defensive-code]
1616
x_ = x_ || e;
1717

1818
u && u.p; // $ Alert[js/unneeded-defensive-code]

0 commit comments

Comments
 (0)