Merge pull request #2428 from erik-krogh/useOfReturnlessFunctionSuperCalls

Approved by max-schaefer

Author: semmle-qlci

javascript/ql/src/Statements/UseOfReturnlessFunction.ql

@@ -222,6 +222,7 @@ where
   not lastStatementHasNoEffect(func) and
   // anonymous one-shot closure. Those are used in weird ways and we ignore them.
   not oneshotClosure(call) and
-  not hasNonVoidReturnType(func)
+  not hasNonVoidReturnType(func) and
+  not call.getEnclosingExpr() instanceof SuperCall
 select
   call, msg, func, name

javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/tst.js

@@ -92,4 +92,16 @@
 
 +function() {
     console.log("FOO");
-}.call(this);
+}.call(this);
+
+class Foo {
+	constructor() {
+		console.log("FOO");
+	}
+}
+
+class Bar extends Foo {
+	constructor() {
+		console.log(super()); // OK.
+	}
+}