Skip to content

Commit f63a3b3

Browse files
author
Esben Sparre Andreasen
committed
JS: add missing abstract modifier
1 parent 6e1846b commit f63a3b3

File tree

6 files changed

+50
-24
lines changed

6 files changed

+50
-24
lines changed

‎javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import javascript
1010
/**
1111
* A call that performs a request to a URL.
1212
*/
13-
class CustomClientRequest extends DataFlow::InvokeNode {
13+
abstract class CustomClientRequest extends DataFlow::InvokeNode {
1414

1515
/**
1616
* Gets the URL of the request.

‎javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequest.expected‎

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,18 @@
1-
| tst.js:11:5:11:16 | request(url) | tst.js:11:13:11:15 | url |
2-
| tst.js:13:5:13:20 | request.get(url) | tst.js:13:17:13:19 | url |
3-
| tst.js:15:5:15:23 | request.delete(url) | tst.js:15:20:15:22 | url |
4-
| tst.js:17:5:17:25 | request ... url }) | tst.js:17:13:17:24 | { url: url } |
5-
| tst.js:17:5:17:25 | request ... url }) | tst.js:17:20:17:22 | url |
6-
| tst.js:19:5:19:23 | requestPromise(url) | tst.js:19:20:19:22 | url |
7-
| tst.js:21:5:21:23 | superagent.get(url) | tst.js:21:20:21:22 | url |
8-
| tst.js:23:5:23:17 | http.get(url) | tst.js:23:14:23:16 | url |
9-
| tst.js:25:5:25:14 | axios(url) | tst.js:25:11:25:13 | url |
10-
| tst.js:27:5:27:18 | axios.get(url) | tst.js:27:15:27:17 | url |
11-
| tst.js:29:5:29:23 | axios({ url: url }) | tst.js:29:11:29:22 | { url: url } |
12-
| tst.js:29:5:29:23 | axios({ url: url }) | tst.js:29:18:29:20 | url |
13-
| tst.js:31:5:31:12 | got(url) | tst.js:31:9:31:11 | url |
14-
| tst.js:33:5:33:19 | got.stream(url) | tst.js:33:16:33:18 | url |
15-
| tst.js:35:5:35:21 | window.fetch(url) | tst.js:35:18:35:20 | url |
16-
| tst.js:37:5:37:18 | nodeFetch(url) | tst.js:37:15:37:17 | url |
17-
| tst.js:39:5:39:20 | net.request(url) | tst.js:39:17:39:19 | url |
18-
| tst.js:41:5:41:29 | net.req ... url }) | tst.js:41:17:41:28 | { url: url } |
19-
| tst.js:41:5:41:29 | net.req ... url }) | tst.js:41:24:41:26 | url |
20-
| tst.js:43:5:43:26 | new Cli ... st(url) | tst.js:43:23:43:25 | url |
21-
| tst.js:45:5:45:35 | new Cli ... url }) | tst.js:45:23:45:34 | { url: url } |
22-
| tst.js:45:5:45:35 | new Cli ... url }) | tst.js:45:30:45:32 | url |
1+
| tst.js:11:5:11:16 | request(url) |
2+
| tst.js:13:5:13:20 | request.get(url) |
3+
| tst.js:15:5:15:23 | request.delete(url) |
4+
| tst.js:17:5:17:25 | request ... url }) |
5+
| tst.js:19:5:19:23 | requestPromise(url) |
6+
| tst.js:21:5:21:23 | superagent.get(url) |
7+
| tst.js:23:5:23:17 | http.get(url) |
8+
| tst.js:25:5:25:14 | axios(url) |
9+
| tst.js:27:5:27:18 | axios.get(url) |
10+
| tst.js:29:5:29:23 | axios({ url: url }) |
11+
| tst.js:31:5:31:12 | got(url) |
12+
| tst.js:33:5:33:19 | got.stream(url) |
13+
| tst.js:35:5:35:21 | window.fetch(url) |
14+
| tst.js:37:5:37:18 | nodeFetch(url) |
15+
| tst.js:39:5:39:20 | net.request(url) |
16+
| tst.js:41:5:41:29 | net.req ... url }) |
17+
| tst.js:43:5:43:26 | new Cli ... st(url) |
18+
| tst.js:45:5:45:35 | new Cli ... url }) |

‎javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequest.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
import javascript
22

33
from ClientRequest r
4-
select r, r.getUrl()
4+
select r

‎javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequest_getUrl.expected‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
| tst.js:11:5:11:16 | request(url) | tst.js:11:13:11:15 | url |
2+
| tst.js:13:5:13:20 | request.get(url) | tst.js:13:17:13:19 | url |
3+
| tst.js:15:5:15:23 | request.delete(url) | tst.js:15:20:15:22 | url |
4+
| tst.js:17:5:17:25 | request ... url }) | tst.js:17:13:17:24 | { url: url } |
5+
| tst.js:17:5:17:25 | request ... url }) | tst.js:17:20:17:22 | url |
6+
| tst.js:19:5:19:23 | requestPromise(url) | tst.js:19:20:19:22 | url |
7+
| tst.js:21:5:21:23 | superagent.get(url) | tst.js:21:20:21:22 | url |
8+
| tst.js:23:5:23:17 | http.get(url) | tst.js:23:14:23:16 | url |
9+
| tst.js:25:5:25:14 | axios(url) | tst.js:25:11:25:13 | url |
10+
| tst.js:27:5:27:18 | axios.get(url) | tst.js:27:15:27:17 | url |
11+
| tst.js:29:5:29:23 | axios({ url: url }) | tst.js:29:11:29:22 | { url: url } |
12+
| tst.js:29:5:29:23 | axios({ url: url }) | tst.js:29:18:29:20 | url |
13+
| tst.js:31:5:31:12 | got(url) | tst.js:31:9:31:11 | url |
14+
| tst.js:33:5:33:19 | got.stream(url) | tst.js:33:16:33:18 | url |
15+
| tst.js:35:5:35:21 | window.fetch(url) | tst.js:35:18:35:20 | url |
16+
| tst.js:37:5:37:18 | nodeFetch(url) | tst.js:37:15:37:17 | url |
17+
| tst.js:39:5:39:20 | net.request(url) | tst.js:39:17:39:19 | url |
18+
| tst.js:41:5:41:29 | net.req ... url }) | tst.js:41:17:41:28 | { url: url } |
19+
| tst.js:41:5:41:29 | net.req ... url }) | tst.js:41:24:41:26 | url |
20+
| tst.js:43:5:43:26 | new Cli ... st(url) | tst.js:43:23:43:25 | url |
21+
| tst.js:45:5:45:35 | new Cli ... url }) | tst.js:45:23:45:34 | { url: url } |
22+
| tst.js:45:5:45:35 | new Cli ... url }) | tst.js:45:30:45:32 | url |

‎javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequest_getUrl.ql‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
import javascript
2+
3+
from ClientRequest r
4+
select r, r.getUrl()

‎javascript/ql/test/library-tests/frameworks/ClientRequests/tst.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,8 @@ import {ClientRequest, net} from 'electron';
4343
new ClientRequest(url);
4444

4545
new ClientRequest({ url: url });
46+
47+
unknown(url);
48+
49+
unknown({ url:url });
4650
});

0 commit comments

Comments
 (0)