Add dot.jssupport

jorgectf · Kwstubbs · jorgectf · commit f1f3d8e18a8b · 2023-06-29T19:17:37.000+02:00
Co-authored-by: Kevin Stubbings &lt;Kwstubbs@users.noreply.github.com&gt;
diff --git a/javascript/extractor/src/com/semmle/js/extractor/FileExtractor.java b/javascript/extractor/src/com/semmle/js/extractor/FileExtractor.java
@@ -103,7 +103,7 @@ private static int skipBOM(byte[] bytes, int length) {
 
   /** Information about supported file types. */
   public static enum FileType {
-    HTML(".htm", ".html", ".xhtm", ".xhtml", ".vue", ".hbs", ".ejs", ".njk", ".erb") {
+    HTML(".htm", ".html", ".xhtm", ".xhtml", ".vue", ".hbs", ".ejs", ".njk", ".erb", ".dot") {
       @Override
       public IExtractor mkExtractor(ExtractorConfig config, ExtractorState state) {
         return new HTMLExtractor(config, state);
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Templating.qll b/javascript/ql/lib/semmle/javascript/frameworks/Templating.qll
@@ -580,6 +580,22 @@ module Templating {
     override string getAPackageName() { result = "ejs" }
   }
 
+  /**
+   * doT-style syntax, using `{{! }}` for safe interpolation, and `{{= }}` for
+   * unsafe interpolation.
+   */
+  private class DotStyleSyntax extends TemplateSyntax {
+    DotStyleSyntax() { this = "dot" }
+
+    override string getRawInterpolationRegexp() { result = "(?s)\\{\\{!(.*?)\\}\\}" }
+
+    override string getEscapingInterpolationRegexp() { result = "(?s)\\{\\{=(.*?)\\}\\}" }
+
+    override string getAFileExtension() { result = "dot" }
+
+    override string getAPackageName() { result = "dot" }
+  }
+
   private TemplateSyntax getOwnTemplateSyntaxInFolder(Folder f) {
     exists(PackageDependencies deps |
       deps.getADependency(result.getAPackageName(), _) and
diff --git a/javascript/ql/test/library-tests/frameworks/Templating/app.js b/javascript/ql/test/library-tests/frameworks/Templating/app.js
@@ -66,3 +66,9 @@ app.get('/angularjs', (req, res) => {
         rawHtml: req.query.rawHtml,
     });
 });
+
+app.get('/dotjs', (req, res) => {
+    res.render('dot_sinks', {
+        tainted: req.query.foo,
+    });
+});
diff --git a/javascript/ql/test/library-tests/frameworks/Templating/views/dot_sinks.dot b/javascript/ql/test/library-tests/frameworks/Templating/views/dot_sinks.dot
@@ -0,0 +1,6 @@
+<html>
+    <body>
+        {{! tainted }}
+        {{= tainted }}
+    </body>
+</html>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +<html>
 +    <body>
 +        {{! tainted }}
 +        {{= tainted }}
 +    </body>
 +</html>