Rust: Restrict macro call stats in DatabaseQualityDiagnostics to extracted files (.fromSource). This is already the case in other places we measure this.

geoffw0 · geoffw0 · commit eea694959e87 · 2025-10-15T11:09:45.000+01:00
diff --git a/rust/ql/src/queries/telemetry/DatabaseQuality.qll b/rust/ql/src/queries/telemetry/DatabaseQuality.qll
@@ -30,9 +30,9 @@ module CallTargetStats implements StatsSig {
 }
 
 module MacroCallTargetStats implements StatsSig {
-  int getNumberOfOk() { result = count(MacroCall c | c.hasMacroCallExpansion()) }
+  int getNumberOfOk() { result = count(MacroCall c | c.fromSource() and c.hasMacroCallExpansion()) }
 
-  additional predicate isNotOkCall(MacroCall c) { not c.hasMacroCallExpansion() }
+  additional predicate isNotOkCall(MacroCall c) { c.fromSource() and not c.hasMacroCallExpansion() }
 
   int getNumberOfNotOk() { result = count(MacroCall c | isNotOkCall(c)) }
 

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,9 @@ module CallTargetStats implements StatsSig {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`module MacroCallTargetStats implements StatsSig {`
`33`		`- int getNumberOfOk() { result = count(MacroCall c \| c.hasMacroCallExpansion()) }`
	`33`	`+ int getNumberOfOk() { result = count(MacroCall c \| c.fromSource() and c.hasMacroCallExpansion()) }`
`34`	`34`
`35`		`- additional predicate isNotOkCall(MacroCall c) { not c.hasMacroCallExpansion() }`
	`35`	`+ additional predicate isNotOkCall(MacroCall c) { c.fromSource() and not c.hasMacroCallExpansion() }`
`36`	`36`
`37`	`37`	`int getNumberOfNotOk() { result = count(MacroCall c \| isNotOkCall(c)) }`
`38`	`38`