JS: Deprecate everything that depends on type extraction

Author: asgerf

javascript/ql/lib/javascript.qll

@@ -47,7 +47,7 @@ import semmle.javascript.NodeJS
 import semmle.javascript.NPM
 import semmle.javascript.Paths
 import semmle.javascript.Promises
-import semmle.javascript.CanonicalNames
+deprecated import semmle.javascript.CanonicalNames
 import semmle.javascript.RangeAnalysis
 import semmle.javascript.Regexp
 import semmle.javascript.Routing

javascript/ql/lib/semmle/javascript/CanonicalNames.qll

@@ -1,6 +1,7 @@
 /**
  * Provides classes for working with name resolution of namespaces and types.
  */
+deprecated module;
 
 import javascript
 
@@ -18,7 +19,7 @@ import javascript
  *
  * This class is only populated when full TypeScript extraction is enabled.
  */
-class CanonicalName extends @symbol {
+deprecated class CanonicalName extends @symbol {
   /**
    * Gets the parent of this canonical name, that is, the prefix of its qualified name.
    */
@@ -218,7 +219,7 @@ class CanonicalName extends @symbol {
 /**
  * The canonical name for a type.
  */
-class TypeName extends CanonicalName {
+deprecated class TypeName extends CanonicalName {
   TypeName() {
     exists(TypeReference ref | type_symbol(ref, this)) or
     exists(TypeDefinition def | ast_node_symbol(def, this)) or
@@ -261,7 +262,7 @@ class TypeName extends CanonicalName {
 /**
  * The canonical name for a namespace.
  */
-class Namespace extends CanonicalName {
+deprecated class Namespace extends CanonicalName {
   Namespace() {
     this.getAChild().isExportedMember() or
     exists(NamespaceDefinition def | ast_node_symbol(def, this)) or
@@ -309,7 +310,7 @@ class Namespace extends CanonicalName {
 /**
  * The canonical name for a function.
  */
-class CanonicalFunctionName extends CanonicalName {
+deprecated class CanonicalFunctionName extends CanonicalName {
   CanonicalFunctionName() {
     exists(Function fun | ast_node_symbol(fun, this)) or
     exists(InvokeExpr invoke | ast_node_symbol(invoke, this))

javascript/ql/lib/semmle/javascript/Classes.qll

@@ -119,7 +119,7 @@ class ClassOrInterface extends @class_or_interface, TypeParameterized {
    *
    * Anonymous classes and interfaces do not have a canonical name.
    */
-  TypeName getTypeName() { result.getADefinition() = this }
+  deprecated TypeName getTypeName() { result.getADefinition() = this }
 
   /**
    * Gets the ClassOrInterface corresponding to either a super type or an implemented interface.

javascript/ql/lib/semmle/javascript/Expr.qll

@@ -176,7 +176,7 @@ class Expr extends @expr, ExprOrStmt, ExprOrType, AST::ValueNode {
    * Has no result if the expression is in a JavaScript file or in a TypeScript
    * file that was extracted without type information.
    */
-  Type getType() { ast_node_type(this, result) }
+  deprecated Type getType() { ast_node_type(this, result) }
 
   /**
    * Holds if the syntactic context that the expression appears in relies on the expression
@@ -993,7 +993,7 @@ class InvokeExpr extends @invokeexpr, Expr {
    *
    * This predicate is only populated for files extracted with full TypeScript extraction.
    */
-  CallSignatureType getResolvedSignature() { invoke_expr_signature(this, result) }
+  deprecated CallSignatureType getResolvedSignature() { invoke_expr_signature(this, result) }
 
   /**
    * Gets the index of the targeted call signature among the overload signatures
@@ -1008,19 +1008,15 @@ class InvokeExpr extends @invokeexpr, Expr {
    *
    * This predicate is only populated for files extracted with full TypeScript extraction.
    */
-  CanonicalFunctionName getResolvedCalleeName() { ast_node_symbol(this, result) }
+  deprecated CanonicalFunctionName getResolvedCalleeName() { ast_node_symbol(this, result) }
 
   /**
    * Gets the statically resolved target function, as determined by the TypeScript type system, if any.
    *
    * Note that the resolved function may be overridden in a subclass and thus is not
    * necessarily the actual target of this invocation at runtime.
    */
-  Function getResolvedCallee() {
-    TypeResolution::callTarget(this, result)
-    or
-    result = this.getResolvedCalleeName().getImplementation()
-  }
+  Function getResolvedCallee() { TypeResolution::callTarget(this, result) }
 }
 
 /**

javascript/ql/lib/semmle/javascript/Functions.qll

@@ -434,12 +434,12 @@ class Function extends @function, Parameterized, TypeParameterized, StmtContaine
    *
    * This predicate is only populated for files extracted with full TypeScript extraction.
    */
-  CanonicalFunctionName getCanonicalName() { ast_node_symbol(this, result) }
+  deprecated CanonicalFunctionName getCanonicalName() { ast_node_symbol(this, result) }
 
   /**
    * Gets the call signature of this function, as determined by the TypeScript compiler, if any.
    */
-  CallSignatureType getCallSignature() { declared_function_signature(this, result) }
+  deprecated CallSignatureType getCallSignature() { declared_function_signature(this, result) }
 }
 
 /**

javascript/ql/lib/semmle/javascript/TypeAnnotations.qll

@@ -135,7 +135,7 @@ class TypeAnnotation extends @type_annotation, NodeInStmtContainer {
    *
    * Note that this has no result for JSDoc type annotations.
    */
-  Type getType() { none() }
+  deprecated Type getType() { none() }
 
   /**
    * Gets the class referenced by this type annotation, if any.