Rust: avoid missing toString for PathSegment without name

Author: aibaars

rust/ql/lib/codeql/rust/elements/internal/PathSegmentImpl.qll

@@ -21,9 +21,13 @@ module Impl {
   class PathSegment extends Generated::PathSegment {
     override string toString() {
       // TODO: this does not cover everything
-      if this.hasGenericArgList()
-      then result = this.getNameRef().toString() + "::<...>"
-      else result = this.getNameRef().toString()
+      exists(string name |
+        name = this.getNameRef().getText()
+        or
+        name = "" and not exists(this.getNameRef())
+      |
+        if this.hasGenericArgList() then result = name + "::<...>" else result = name
+      )
     }
   }
 }

rust/ql/test/extractor-tests/types/types.expected

@@ -76,7 +76,7 @@ exprTypes
 | main.rs:47:14:47:18 | false | bool |
 | main.rs:51:14:53:1 | BlockExpr | () |
 | main.rs:52:5:52:11 | $crate::boxed::Box::new | fn new<[i32; 1]>([i32; 1]) -> Box<[i32; 1], Global> |
-| main.rs:52:5:52:11 | (no string representation) | fn into_vec<i32, Global>(Box<[i32], Global>) -> Vec<i32, Global> |
+| main.rs:52:5:52:11 | ::into_vec | fn into_vec<i32, Global>(Box<[i32], Global>) -> Vec<i32, Global> |
 | main.rs:52:5:52:11 | MacroExpr | Vec<i32, Global> |
 | main.rs:52:10:52:10 | 1 | i32 |
 | main.rs:52:10:52:10 | ArrayExpr | [i32; 1] |