Skip to content

Commit ec8ced7

Browse files
committed
TS: Fix a typos and leftover todo
1 parent 01ab8f0 commit ec8ced7

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

javascript/extractor/src/com/semmle/js/ast/AFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class AFunction<B> {
1919
private final List<ITypeExpression> parameterTypes;
2020
private final ITypeExpression thisParameterType;
2121
private final List<DecoratorList> parameterDecorators;
22-
private final IntList optionalParmaeterIndices;
22+
private final IntList optionalParameterIndices;
2323

2424
public static final IntList noOptionalParams = IntList.create(0, 0);
2525

@@ -34,7 +34,7 @@ public AFunction(
3434
List<DecoratorList> parameterDecorators,
3535
ITypeExpression returnType,
3636
ITypeExpression thisParameterType,
37-
IntList optionalParmaeterIndices) {
37+
IntList optionalParameterIndices) {
3838
this.id = id;
3939
this.params = new ArrayList<IPattern>(params.size());
4040
this.defaults = new ArrayList<Expression>(params.size());
@@ -47,7 +47,7 @@ public AFunction(
4747
this.returnType = returnType;
4848
this.thisParameterType = thisParameterType;
4949
this.parameterDecorators = parameterDecorators;
50-
this.optionalParmaeterIndices = optionalParmaeterIndices;
50+
this.optionalParameterIndices = optionalParameterIndices;
5151

5252
IPattern rest = null;
5353
for (Expression param : params) {
@@ -151,6 +151,6 @@ public List<DecoratorList> getParameterDecorators() {
151151
}
152152

153153
public IntList getOptionalParmaeterIndices() {
154-
return optionalParmaeterIndices;
154+
return optionalParameterIndices;
155155
}
156156
}

javascript/extractor/src/com/semmle/js/parser/TypeScriptASTConverter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,6 @@ private IntList getOptionalParameterIndices(JsonObject function) throws ParseErr
19031903
++index;
19041904
if (param.getAsJsonObject().has("questionToken")) {
19051905
list.add(index);
1906-
;
19071906
}
19081907
}
19091908
return list;

javascript/ql/src/semmle/javascript/TypeScript.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2618,7 +2618,7 @@ class CallSignatureType extends @signature_type {
26182618
/**
26192619
* Holds if this signature declares a rest parameter, such as `(x: number, ...y: string[])`.
26202620
*/
2621-
predicate hasRestParameter() { signature_rest_parameter(this, _) } // TODO
2621+
predicate hasRestParameter() { signature_rest_parameter(this, _) }
26222622

26232623
/**
26242624
* Gets the type of the rest parameter, if any.

0 commit comments

Comments
 (0)