Merge pull request #10998 from RasmusWL/essa-use-use-test

Python: Add failing ESSA use-use test

Author: RasmusWL

python/ql/test/library-tests/essa/ssa-compute/UseUse.expected

@@ -0,0 +1,41 @@
+import python
+import semmle.python.essa.SsaCompute
+import TestUtilities.InlineExpectationsTest
+
+class UseTest extends InlineExpectationsTest {
+  UseTest() { this = "UseTest" }
+
+  override string getARelevantTag() { result in ["use-use", "def-use", "def"] }
+
+  override predicate hasActualResult(Location location, string element, string tag, string value) {
+    exists(location.getFile().getRelativePath()) and
+    exists(string name | name in ["x", "y"] |
+      exists(NameNode nodeTo, Location prevLoc |
+        (
+          exists(NameNode nodeFrom | AdjacentUses::adjacentUseUse(nodeFrom, nodeTo) |
+            prevLoc = nodeFrom.getLocation() and
+            name = nodeFrom.getId() and
+            tag = "use-use"
+          )
+          or
+          exists(EssaVariable var | AdjacentUses::firstUse(var, nodeTo) |
+            prevLoc = var.getLocation() and
+            name = var.getName() and
+            tag = "def-use"
+          )
+        ) and
+        value = name + ":" + prevLoc.getStartLine() and
+        location = nodeTo.getLocation() and
+        element = nodeTo.toString()
+      )
+      or
+      exists(EssaVariable var | AdjacentUses::firstUse(var, _) |
+        value = var.getName() and
+        location = var.getLocation() and
+        element = var.getName() and
+        name = var.getName() and
+        tag = "def"
+      )
+    )
+  }
+}

python/ql/test/library-tests/essa/ssa-compute/UseUse.ql

@@ -0,0 +1,20 @@
+class X(object):
+    def foo(self, *args):
+        print("X.foo", args)
+
+
+def func(cond=True):
+    x = X() # $ def=x
+
+    print(x) # $ def-use=x:7
+
+    y = x # $ def=y use-use=x:9
+    print(y) # $ def-use=y:11
+
+    x.foo() # $ use-use=x:11
+
+    x.foo(1 if cond else 0) # $ use-use=x:14
+    x.foo() # $ MISSING: use-use=x:16
+    print(x) # $ use-use=x:17
+
+func()