Merge pull request #10075 from erik-krogh/depOld

delete old deprecations

Author: erik-krogh

cpp/ql/lib/change-notes/2022-08-17-deleted-deprecations.md

@@ -0,0 +1,6 @@
+---
+category: minorAnalysis
+---
+* All deprecated predicates/classes/modules that have been deprecated for over a year have been 
+deleted.
+

cpp/ql/lib/semmle/code/cpp/models/implementations/StdPair.qll

@@ -11,12 +11,6 @@ private class StdPair extends ClassTemplateInstantiation {
   StdPair() { this.hasQualifiedName(["std", "bsl"], "pair") }
 }
 
-/**
- * DEPRECATED: This is now called `StdPair` and is a private part of the
- * library implementation.
- */
-deprecated class StdPairClass = StdPair;
-
 /**
  * Any of the single-parameter constructors of `std::pair` that takes a reference to an
  * instantiation of `std::pair`. These constructors allow conversion between pair types when the

cpp/ql/lib/semmle/code/cpp/models/interfaces/FlowSource.qll

@@ -27,13 +27,6 @@ abstract class RemoteFlowSourceFunction extends Function {
   predicate hasSocketInput(FunctionInput input) { none() }
 }
 
-/**
- * DEPRECATED: Use `RemoteFlowSourceFunction` instead.
- *
- * A library function that returns data that may be read from a network connection.
- */
-deprecated class RemoteFlowFunction = RemoteFlowSourceFunction;
-
 /**
  * A library function that returns data that is directly controlled by a user.
  */
@@ -44,13 +37,6 @@ abstract class LocalFlowSourceFunction extends Function {
   abstract predicate hasLocalFlowSource(FunctionOutput output, string description);
 }
 
-/**
- * DEPRECATED: Use `LocalFlowSourceFunction` instead.
- *
- * A library function that returns data that is directly controlled by a user.
- */
-deprecated class LocalFlowFunction = LocalFlowSourceFunction;
-
 /** A library function that sends data over a network connection. */
 abstract class RemoteFlowSinkFunction extends Function {
   /**

csharp/ql/lib/change-notes/2022-08-17-deleted-deprecations.md

@@ -0,0 +1,6 @@
+---
+category: minorAnalysis
+---
+* All deprecated predicates/classes/modules that have been deprecated for over a year have been 
+deleted.
+

csharp/ql/lib/semmle/code/cil/DataFlow.qll

@@ -109,125 +109,6 @@ private predicate localTaintStep(DataFlowNode src, DataFlowNode sink) {
   src = sink.(UnaryBitwiseOperation).getOperand()
 }
 
-deprecated module DefUse {
-  /**
-   * A classification of variable references into reads and writes.
-   */
-  private newtype RefKind =
-    Read() or
-    Write()
-
-  /**
-   * Holds if the `i`th node of basic block `bb` is a reference to `v`,
-   * either a read (when `k` is `Read()`) or a write (when `k` is `Write()`).
-   */
-  private predicate ref(BasicBlock bb, int i, StackVariable v, RefKind k) {
-    exists(ReadAccess ra | bb.getNode(i) = ra |
-      ra.getTarget() = v and
-      k = Read()
-    )
-    or
-    exists(VariableUpdate vu | bb.getNode(i) = vu |
-      vu.getVariable() = v and
-      k = Write()
-    )
-  }
-
-  /**
-   * Gets the (1-based) rank of the reference to `v` at the `i`th node of
-   * basic block `bb`, which has the given reference kind `k`.
-   */
-  private int refRank(BasicBlock bb, int i, StackVariable v, RefKind k) {
-    i = rank[result](int j | ref(bb, j, v, _)) and
-    ref(bb, i, v, k)
-  }
-
-  /**
-   * Holds if stack variable `v` is live at the beginning of basic block `bb`.
-   */
-  private predicate liveAtEntry(BasicBlock bb, StackVariable v) {
-    // The first reference to `v` inside `bb` is a read
-    refRank(bb, _, v, Read()) = 1
-    or
-    // There is no reference to `v` inside `bb`, but `v` is live at entry
-    // to a successor basic block of `bb`
-    not exists(refRank(bb, _, v, _)) and
-    liveAtExit(bb, v)
-  }
-
-  /**
-   * Holds if stack variable `v` is live at the end of basic block `bb`.
-   */
-  private predicate liveAtExit(BasicBlock bb, StackVariable v) {
-    liveAtEntry(bb.getASuccessor(), v)
-  }
-
-  /**
-   * Holds if the variable update `vu` reaches rank index `rankix`
-   * in its own basic block `bb`.
-   */
-  private predicate defReachesRank(BasicBlock bb, VariableUpdate vu, int rankix, StackVariable v) {
-    exists(int i |
-      rankix = refRank(bb, i, v, Write()) and
-      vu = bb.getNode(i)
-    )
-    or
-    defReachesRank(bb, vu, rankix - 1, v) and
-    rankix = refRank(bb, _, v, Read())
-  }
-
-  /**
-   * Holds if the variable update `vu` of stack variable `v` reaches the
-   * end of a basic block `bb`, at which point it is still live, without
-   * crossing another update.
-   */
-  private predicate defReachesEndOfBlock(BasicBlock bb, VariableUpdate vu, StackVariable v) {
-    liveAtExit(bb, v) and
-    (
-      exists(int last | last = max(refRank(bb, _, v, _)) | defReachesRank(bb, vu, last, v))
-      or
-      defReachesStartOfBlock(bb, vu, v) and
-      not exists(refRank(bb, _, v, Write()))
-    )
-  }
-
-  pragma[noinline]
-  private predicate defReachesStartOfBlock(BasicBlock bb, VariableUpdate vu, StackVariable v) {
-    defReachesEndOfBlock(bb.getAPredecessor(), vu, v)
-  }
-
-  /**
-   * Holds if the variable update `vu` of stack variable `v` reaches `read` in the
-   * same basic block without crossing another update of `v`.
-   */
-  private predicate defReachesReadWithinBlock(StackVariable v, VariableUpdate vu, ReadAccess read) {
-    exists(BasicBlock bb, int rankix, int i |
-      defReachesRank(bb, vu, rankix, v) and
-      rankix = refRank(bb, i, v, Read()) and
-      read = bb.getNode(i)
-    )
-  }
-
-  /** Holds if the variable update `vu` can be used at the read `use`. */
-  cached
-  deprecated predicate variableUpdateUse(StackVariable target, VariableUpdate vu, ReadAccess use) {
-    defReachesReadWithinBlock(target, vu, use)
-    or
-    exists(BasicBlock bb, int i |
-      exists(refRank(bb, i, target, Read())) and
-      use = bb.getNode(i) and
-      defReachesEndOfBlock(bb.getAPredecessor(), vu, target) and
-      not defReachesReadWithinBlock(target, _, use)
-    )
-  }
-
-  /** Holds if the update `def` can be used at the read `use`. */
-  cached
-  deprecated predicate defUse(StackVariable target, Expr def, ReadAccess use) {
-    exists(VariableUpdate vu | def = vu.getSource() | variableUpdateUse(target, vu, use))
-  }
-}
-
 /** A node that updates a variable. */
 abstract class VariableUpdate extends DataFlowNode {
   /** Gets the value assigned, if any. */