Merge pull request #3121 from dbartol/dbartol/ir-generate-all-fixup

Robert Marsh · web-flow · commit e6cdbb9bd220 · 2020-03-25T17:58:01.000-07:00
C++: Late fix for PR feedback
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {
     result = getResultString() + " = " + getOperationString() + " " + getOperandsString()
   }
 
-  predicate shouldGenerateDumpStrings() {
+  private predicate shouldGenerateDumpStrings() {
     exists(IRConfiguration::IRConfiguration config |
       config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())
     )
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {
     result = getResultString() + " = " + getOperationString() + " " + getOperandsString()
   }
 
-  predicate shouldGenerateDumpStrings() {
+  private predicate shouldGenerateDumpStrings() {
     exists(IRConfiguration::IRConfiguration config |
       config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())
     )
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {
     result = getResultString() + " = " + getOperationString() + " " + getOperandsString()
   }
 
-  predicate shouldGenerateDumpStrings() {
+  private predicate shouldGenerateDumpStrings() {
     exists(IRConfiguration::IRConfiguration config |
       config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())
     )
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll
@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {
     result = getResultString() + " = " + getOperationString() + " " + getOperandsString()
   }
 
-  predicate shouldGenerateDumpStrings() {
+  private predicate shouldGenerateDumpStrings() {
     exists(IRConfiguration::IRConfiguration config |
       config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())
     )
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {
     result = getResultString() + " = " + getOperationString() + " " + getOperandsString()
   }
 
-  predicate shouldGenerateDumpStrings() {
+  private predicate shouldGenerateDumpStrings() {
     exists(IRConfiguration::IRConfiguration config |
       config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())
     )

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ class Instruction extends Construction::TInstruction {`
`42`	`42`	`result = getResultString() + " = " + getOperationString() + " " + getOperandsString()`
`43`	`43`	`}`
`44`	`44`
`45`		`- predicate shouldGenerateDumpStrings() {`
	`45`	`+ private predicate shouldGenerateDumpStrings() {`
`46`	`46`	`exists(IRConfiguration::IRConfiguration config \|`
`47`	`47`	`config.shouldEvaluateDebugStringsForFunction(this.getEnclosingFunction())`
`48`	`48`	`)`