PS: Consistent lower casing in api graphs, control-flow graph, and dataflow nodes.

Author: MathiasVP

powershell/ql/lib/semmle/code/powershell/ApiGraphs.qll

@@ -563,15 +563,15 @@ module API {
         )
         or
         exists(DataFlow::AutomaticVariableNode automatic |
-          automatic.getName() = name and
+          automatic.getLowerCaseName() = name and
           succ = getForwardStartNode(automatic)
         )
         or
         succ = getAnImplicitRootMember(name)
       )
       or
       exists(DataFlow::QualifiedTypeNameNode typeName |
-        typeName.getName() = name and
+        typeName.getLowerCaseName() = name and
         pred = MkNamespaceOfTypeNameNode(typeName) and
         succ = getForwardStartNode(typeName)
       )

powershell/ql/lib/semmle/code/powershell/controlflow/CfgNodes.qll

@@ -587,7 +587,15 @@ module ExprNodes {
 
     override ObjectCreation getExpr() { result = e }
 
-    string getConstructedTypeName() { result = this.getExpr().getConstructedTypeName() }
+    string getLowerCaseConstructedTypeName() {
+      result = this.getExpr().getLowerCaseConstructedTypeName()
+    }
+
+    bindingset[result]
+    pragma[inline_late]
+    string getAConstructedTypeName() {
+      result.toLowerCase() = this.getLowerCaseConstructedTypeName()
+    }
 
     ExprCfgNode getConstructedTypeExpr() {
       e.hasCfgChild(this.getExpr().getConstructedTypeExpr(), this, result)
@@ -717,7 +725,11 @@ module ExprNodes {
 
     override TypeNameExpr getExpr() { result = e }
 
-    string getName() { result = e.getName() }
+    bindingset[result]
+    pragma[inline_late]
+    string getAName() { result = e.getAName() }
+
+    string getLowerCaseName() { result = e.getLowerCaseName() }
 
     string getNamespace() { result = e.getNamespace() }
 
@@ -1118,7 +1130,11 @@ module ExprNodes {
 
     override AutomaticVariable getExpr() { result = e }
 
-    string getName() { result = e.getName() }
+    bindingset[result]
+    pragma[inline_late]
+    string getAName() { result = e.getAName() }
+
+    string getLowerCaseName() { result = e.getLowerCaseName() }
   }
 }
 

powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowDispatch.qll

@@ -159,10 +159,10 @@ private predicate localFlowStep(Node nodeFrom, Node nodeTo, StepSummary summary)
 
 private module TrackInstanceInput implements CallGraphConstruction::InputSig {
   private predicate start0(Node start, string typename, boolean exact) {
-    start.(ObjectCreationNode).getObjectCreationNode().getConstructedTypeName() = typename and
+    start.(ObjectCreationNode).getObjectCreationNode().getLowerCaseConstructedTypeName() = typename and
     exact = true
     or
-    start.asExpr().(CfgNodes::ExprNodes::TypeNameExprCfgNode).getName() = typename and
+    start.asExpr().(CfgNodes::ExprNodes::TypeNameExprCfgNode).getLowerCaseName() = typename and
     exact = true
     or
     start.asParameter().getStaticType() = typename and

powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPublic.qll

@@ -495,7 +495,11 @@ class ObjectCreationNode extends ExprNode {
    */
   Node getConstructedTypeNode() { result.asExpr() = objectCreation.getConstructedTypeExpr() }
 
-  string getConstructedTypeName() { result = this.getObjectCreationNode().getConstructedTypeName() }
+  bindingset[result]
+  pragma[inline_late]
+  string getAConstructedTypeName() {
+    result = this.getObjectCreationNode().getAConstructedTypeName()
+  }
 }
 
 /** A call, viewed as a node in a data flow graph. */
@@ -567,7 +571,11 @@ class TypeNameNode extends ExprNode {
 
   override CfgNodes::ExprNodes::TypeNameExprCfgNode getExprNode() { result = n }
 
-  string getName() { result = n.getName() }
+  bindingset[result]
+  pragma[inline_late]
+  string getAName() { result = n.getAName() }
+
+  string getLowerCaseName() { result = n.getLowerCaseName() }
 
   predicate isQualified() { n.isQualified() }
 
@@ -593,5 +601,9 @@ class AutomaticVariableNode extends ExprNode {
 
   final override CfgNodes::ExprNodes::AutomaticVariableCfgNode getExprNode() { result = n }
 
-  string getName() { result = n.getName() }
+  bindingset[result]
+  pragma[inline_late]
+  string getAName() { result = n.getAName() }
+
+  string getLowerCaseName() { result = n.getLowerCaseName() }
 }