Update tests

Author: owen-mc

go/ql/test/library-tests/semmle/go/dataflow/ArrayConversion/main.go

@@ -16,8 +16,8 @@ func main() {
 	var a [4]string
 	a[0] = source()
 	alias := [2]string(a[:])
-	sink(alias[0]) // $ hasTaintFlow="index expression"
-	sink(alias[1]) // $ SPURIOUS: hasTaintFlow="index expression" // we don't distinguish different elements of arrays or slices
+	sink(alias[0]) // $ hasValueFlow="index expression"
+	sink(alias[1]) // $ SPURIOUS: hasValueFlow="index expression" // we don't distinguish different elements of arrays or slices
 	sink(alias)    // $ hasTaintFlow="alias"
 
 	// Compare with the standard dataflow support for arrays

go/ql/test/library-tests/semmle/go/dataflow/SliceExpressions/main.go

@@ -15,31 +15,31 @@ func main() {
 func arrayBase(base [4]string) {
 	base[1] = source()
 	slice := base[1:4]
-	sink(slice[0]) // $ hasTaintFlow="index expression"
-	sink(slice[1]) // $ SPURIOUS: hasTaintFlow="index expression" // we don't distinguish different elements of arrays or slices
+	sink(slice[0]) // $ hasValueFlow="index expression"
+	sink(slice[1]) // $ SPURIOUS: hasValueFlow="index expression" // we don't distinguish different elements of arrays or slices
 	sink(slice)    // $ hasTaintFlow="slice"
 }
 
 func arrayPointerBase(base *[4]string) {
 	base[1] = source()
 	slice := base[1:4]
-	sink(slice[0]) // $ hasTaintFlow="index expression"
-	sink(slice[1]) // $ SPURIOUS: hasTaintFlow="index expression" // we don't distinguish different elements of arrays or slices
+	sink(slice[0]) // $ hasValueFlow="index expression"
+	sink(slice[1]) // $ SPURIOUS: hasValueFlow="index expression" // we don't distinguish different elements of arrays or slices
 	sink(slice)    // $ hasTaintFlow="slice"
 }
 
 func sliceBase(base []string) {
 	base[1] = source()
 	slice := base[1:4]
-	sink(slice[0]) // $ hasTaintFlow="index expression"
-	sink(slice[1]) // $ SPURIOUS: hasTaintFlow="index expression" // we don't distinguish different elements of arrays or slices
+	sink(slice[0]) // $ hasValueFlow="index expression"
+	sink(slice[1]) // $ SPURIOUS: hasValueFlow="index expression" // we don't distinguish different elements of arrays or slices
 	sink(slice)    // $ hasTaintFlow="slice"
 }
 
 func slicePointerBase(base *[]string) {
 	(*base)[1] = source()
 	slice := (*base)[1:4]
-	sink(slice[0]) // $ hasTaintFlow="index expression"
-	sink(slice[1]) // $ SPURIOUS: hasTaintFlow="index expression" // we don't distinguish different elements of arrays or slices
+	sink(slice[0]) // $ hasValueFlow="index expression"
+	sink(slice[1]) // $ SPURIOUS: hasValueFlow="index expression" // we don't distinguish different elements of arrays or slices
 	sink(slice)    // $ hasTaintFlow="slice"
 }