Merge pull request #11302 from tamasvajk/kotlin-ignored-return

Kotlin: Exclude .kt files from ignored return value query

Author: tamasvajk

java/ql/src/Likely Bugs/Statements/ReturnValueIgnored.ql

@@ -75,6 +75,7 @@ predicate isMustBeQualifierMockingMethod(Method m) {
 
 predicate relevantMethodCall(MethodAccess ma, Method m) {
   // For "return value ignored", all method calls are relevant.
+  not ma.getFile().isKotlinSourceFile() and
   ma.getMethod() = m and
   not m.getReturnType().hasName("void") and
   (not isMockingMethod(m) or isMustBeQualifierMockingMethod(m)) and

java/ql/test/kotlin/query-tests/ReturnValueIgnored/ReturnValueIgnored.expected

@@ -0,0 +1 @@
+Likely Bugs/Statements/ReturnValueIgnored.ql

java/ql/test/kotlin/query-tests/ReturnValueIgnored/ReturnValueIgnored.qlref

@@ -0,0 +1,16 @@
+class Foo {
+    fun foo(): Int { return 5 }
+    fun bar() {
+        val x0 = foo()
+        val x1 = foo()
+        val x2 = foo()
+        val x3 = foo()
+        val x4 = foo()
+        val x5 = foo()
+        val x6 = foo()
+        val x7 = foo()
+        val x8 = foo()
+        val x9 = foo()
+        val x = if (true) { foo() } else 6
+    }
+}