JS: Make overriding ConsistencyChecking.getATestFile() optional

asgerf · asgerf · commit dea185b34835 · 2023-10-09T13:58:30.000+02:00
diff --git a/javascript/ql/test/testUtilities/ConsistencyChecking.qll b/javascript/ql/test/testUtilities/ConsistencyChecking.qll
@@ -129,7 +129,7 @@ private predicate falseNegative(File file, int line, AssertionComment comment, C
 private File getATestFile(string conf) {
   not exists(any(ConsistencyConfiguration res).getAFile()) and
   result = any(LineComment comment).getFile() and
-  conf = ""
+  (conf = "" or conf instanceof ConsistencyConfiguration)
   or
   result = conf.(ConsistencyConfiguration).getAFile()
 }

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ private predicate falseNegative(File file, int line, AssertionComment comment, C`
`129`	`129`	`private File getATestFile(string conf) {`
`130`	`130`	`not exists(any(ConsistencyConfiguration res).getAFile()) and`
`131`	`131`	`result = any(LineComment comment).getFile() and`
`132`		`- conf = ""`
	`132`	`+ (conf = "" or conf instanceof ConsistencyConfiguration)`
`133`	`133`	`or`
`134`	`134`	`result = conf.(ConsistencyConfiguration).getAFile()`
`135`	`135`	`}`