Skip to content

Commit ddd65d4

Browse files
committed
Fix node1,node2 being swapped when using exportsObjectRhs in commonStep
1 parent b04157b commit ddd65d4

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

javascript/ql/lib/semmle/javascript/internal/NameResolution.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,10 @@ module NameResolution {
209209
private predicate commonStep(Node node1, Node node2) {
210210
commonStep1(node1, node2)
211211
or
212-
node2 = exportsObjectRhs(node1)
212+
exists(ModuleLike mod |
213+
node1 = exportsObjectRhs(mod) and
214+
node2 = mod
215+
)
213216
}
214217

215218
/**

0 commit comments

Comments
 (0)