C++: Add some test cases for the mirror case, with <=.

geoffw0 · geoffw0 · commit dcf2f7f19c22 · 2020-03-16T13:22:00.000Z
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/UnsignedGEZero/UnsignedGEZero.c b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/UnsignedGEZero/UnsignedGEZero.c
@@ -130,4 +130,11 @@ void myFunction() {
 	}
 	if ((signed int)(unsigned char)(signed char)si >= 0) { // violation
 	}
+
+	if (ui <= 0) {
+	}
+	if (0 <= ui) { // violation [NOT DETECTED]
+	}
+	if (0 < ui) {
+	}
 }
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/UnsignedGEZero/UnsignedGEZero.cpp b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/UnsignedGEZero/UnsignedGEZero.cpp
@@ -130,4 +130,11 @@ void myFunction() {
 	}
 	if ((signed int)(unsigned char)(signed char)si >= 0) { // violation
 	}
+
+	if (ui <= 0) {
+	}
+	if (0 <= ui) { // violation [NOT DETECTED]
+	}
+	if (0 < ui) {
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -130,4 +130,11 @@ void myFunction() {`
`130`	`130`	`}`
`131`	`131`	`if ((signed int)(unsigned char)(signed char)si >= 0) { // violation`
`132`	`132`	`}`
	`133`	`+`
	`134`	`+ if (ui <= 0) {`
	`135`	`+ }`
	`136`	`+ if (0 <= ui) { // violation [NOT DETECTED]`
	`137`	`+ }`
	`138`	`+ if (0 < ui) {`
	`139`	`+ }`
`133`	`140`	`}`