Skip to content

Commit da3e960

Browse files
committed
JS: address review comments
1 parent 9b10254 commit da3e960

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

javascript/ql/src/semmle/javascript/dataflow/Configuration.qll

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,12 +311,17 @@ abstract class BarrierGuardNode extends DataFlow::Node {
311311
abstract predicate blocks(boolean outcome, Expr e);
312312

313313
/**
314-
* Holds if this barrier guard blocks all labels.
314+
* Holds if this barrier guard should block all labels.
315+
*
316+
* To block specific labels only, subclasses should override this with `none()` and
317+
* also override `blocksSpecificLabel`.
315318
*/
316319
predicate blocksAllLabels() { any() }
317320

318321
/**
319322
* Holds if this barrier guard only blocks specific labels, and `label` is one of them.
323+
*
324+
* Subclasses that override this predicate should also override `blocksAllLabels`.
320325
*/
321326
predicate blocksSpecificLabel(FlowLabel label) { none() }
322327
}

javascript/ql/src/semmle/javascript/security/TaintedObject.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ module TaintedObject {
2222
}
2323

2424
/**
25-
* Gets the flow label representing a deeply tainted objects.
25+
* Gets the flow label representing a deeply tainted object.
2626
*
27-
* A "tainted object" is an array or object whose values are all assumed to be tainted as well.
27+
* A "tainted object" is an array or object whose properties values are all assumed to be tainted as well.
2828
*
29-
* Note that the presence of the `object-taint` label generally implies the presence of the `taint` label as well.
29+
* Note that the presence of the this label generally implies the presence of the `taint` label as well.
3030
*/
3131
FlowLabel label() { result instanceof TaintedObjectLabel }
3232

0 commit comments

Comments
 (0)