Swift/CleartextStorageDatabaseQuery

d10c · d10c · commit da192f654035 · 2025-10-14T17:06:21.000+02:00
swift/ql/src/queries/Security/CWE-311/CleartextStorageDatabase.ql
diff --git a/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseQuery.qll b/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseQuery.qll
@@ -52,12 +52,9 @@ module CleartextStorageDatabaseConfig implements DataFlow::ConfigSig {
   predicate observeDiffInformedIncrementalMode() { any() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    exists(DataFlow::Node cleanSink | result = cleanSink.getLocation() |
-      cleanSink = sink.(DataFlow::PostUpdateNode).getPreUpdateNode()
-      or
-      not sink instanceof DataFlow::PostUpdateNode and
-      cleanSink = sink
-    )
+    result = sink.(CleartextStorageDatabaseSink).getLocation()
+    or
+    result = sink.(DataFlow::PostUpdateNode).getPreUpdateNode().getLocation()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -52,12 +52,9 @@ module CleartextStorageDatabaseConfig implements DataFlow::ConfigSig {`
`52`	`52`	`predicate observeDiffInformedIncrementalMode() { any() }`
`53`	`53`
`54`	`54`	`Location getASelectedSinkLocation(DataFlow::Node sink) {`
`55`		`- exists(DataFlow::Node cleanSink \| result = cleanSink.getLocation() \|`
`56`		`- cleanSink = sink.(DataFlow::PostUpdateNode).getPreUpdateNode()`
`57`		`- or`
`58`		`- not sink instanceof DataFlow::PostUpdateNode and`
`59`		`- cleanSink = sink`
`60`		`- )`
	`55`	`+ result = sink.(CleartextStorageDatabaseSink).getLocation()`
	`56`	`+ or`
	`57`	`+ result = sink.(DataFlow::PostUpdateNode).getPreUpdateNode().getLocation()`
`61`	`58`	`}`
`62`	`59`	`}`
`63`	`60`