JS: push negation

Esben Sparre Andreasen · Esben Sparre Andreasen · commit d813a7cad29c · 2018-11-08T13:23:19.000+01:00
diff --git a/javascript/ql/src/Declarations/DeadStoreOfProperty.ql b/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
@@ -20,7 +20,7 @@ predicate unambiguousPropWrite(DataFlow::SourceNode base, string name, Assignmen
     assign.getLhs().flow() = lhs and
     base.getAPropertyWrite(name) = lhs and
     not exists (DataFlow::SourceNode otherBase |
-      not otherBase = base and
+      otherBase != base and
       lhs = otherBase.getAPropertyWrite(name)
     )
   )

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ predicate unambiguousPropWrite(DataFlow::SourceNode base, string name, Assignmen`
`20`	`20`	`assign.getLhs().flow() = lhs and`
`21`	`21`	`base.getAPropertyWrite(name) = lhs and`
`22`	`22`	`not exists (DataFlow::SourceNode otherBase \|`
`23`		`- not otherBase = base and`
	`23`	`+ otherBase != base and`
`24`	`24`	`lhs = otherBase.getAPropertyWrite(name)`
`25`	`25`	`)`
`26`	`26`	`)`