C#: Change asp.net core view generation to be opt out

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -112,10 +112,10 @@ public DependencyManager(string srcDir, IDependencyOptions options, ILogger logg
             }
 
             var webViewExtractionOption = Environment.GetEnvironmentVariable("CODEQL_EXTRACTOR_CSHARP_STANDALONE_EXTRACT_WEB_VIEWS");
-            if (bool.TryParse(webViewExtractionOption, out var shouldExtractWebViews) &&
+            if (webViewExtractionOption == null ||
+                bool.TryParse(webViewExtractionOption, out var shouldExtractWebViews) &&
                 shouldExtractWebViews)
             {
-                logger.LogInfo("Generating source files from cshtml and razor files...");
                 GenerateSourceFilesFromWebViews(allNonBinaryFiles);
             }
 
@@ -445,6 +445,14 @@ private void GenerateSourceFilesFromWebViews(List<FileInfo> allFiles)
 
             logger.LogInfo($"Found {views.Length} cshtml and razor files.");
 
+            if (!fileContent.IsNewProjectStructureUsed)
+            {
+                logger.LogInfo("Generating source files from cshtml files is only supported for new (SDK-style) project files");
+                return;
+            }
+
+            logger.LogInfo("Generating source files from cshtml and razor files...");
+
             var sdk = new Sdk(dotnet).GetNewestSdk();
             if (sdk != null)
             {

csharp/ql/integration-tests/all-platforms/cshtml_standalone/test.py

@@ -1,6 +1,4 @@
 import os
 from create_database_utils import *
 
-
-os.environ['CODEQL_EXTRACTOR_CSHARP_STANDALONE_EXTRACT_WEB_VIEWS'] = 'true'
 run_codeql_database_create(lang="csharp", extra_args=["--extractor-option=buildless=true", "--extractor-option=cil=false"])

csharp/ql/integration-tests/all-platforms/cshtml_standalone_flowsteps/test.py

@@ -1,6 +1,4 @@
 import os
 from create_database_utils import *
 
-
-os.environ['CODEQL_EXTRACTOR_CSHARP_STANDALONE_EXTRACT_WEB_VIEWS'] = 'true'
 run_codeql_database_create(lang="csharp", extra_args=["--extractor-option=buildless=true", "--extractor-option=cil=false"])