Skip to content

Commit d7c2f9d

Browse files
committed
C++: Remove @precision from AV Rule 78
This rule, named "No virtual destructor", was supposed to be superseded by `cpp/virtual-destructor` in 0c796de, but that commit didn't actually disable this rule, so both rules are now active in the LGTM suite. This commit disables the rule by removing `@precision`. We're still discussing the best way to disable rules that are precise and valid but not universally applicable. For now, removing `@precision` is consistent with how we're keeping most other JSF queries from appearing on LGTM.
1 parent cc28d04 commit d7c2f9d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

cpp/ql/src/jsf/4.10 Classes/AV Rule 78.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* @description All base classes with a virtual function should define a virtual destructor. If an application attempts to delete a derived class object through a base class pointer, the result is undefined if the base class destructor is non-virtual.
44
* @kind problem
55
* @problem.severity warning
6-
* @precision high
76
* @id cpp/jsf/av-rule-78
87
* @tags reliability
98
* readability

0 commit comments

Comments
 (0)