JavaScript: Introduce two more short-circuiting conjuncts.

Max Schaefer · Max Schaefer · commit d6198fcc2a9a · 2018-11-14T09:33:09.000Z
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -744,6 +744,7 @@ private predicate onPath(DataFlow::Node nd, DataFlow::Configuration cfg,
  */
 private newtype TPathNode =
   MkPathNode(DataFlow::Node nd, DataFlow::Configuration cfg, PathSummary summary) {
+    isSource(_, cfg, _) and isSink(_, cfg, _) and
     onPath(nd, cfg, summary)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -744,6 +744,7 @@ private predicate onPath(DataFlow::Node nd, DataFlow::Configuration cfg,`
`744`	`744`	`*/`
`745`	`745`	`private newtype TPathNode =`
`746`	`746`	`MkPathNode(DataFlow::Node nd, DataFlow::Configuration cfg, PathSummary summary) {`
	`747`	`+ isSource(_, cfg, _) and isSink(_, cfg, _) and`
`747`	`748`	`onPath(nd, cfg, summary)`
`748`	`749`	`}`
`749`	`750`