Skip to content

Commit d59ea3d

Browse files
authored
Merge pull request #2466 from esbena/js/fix-mjs-check
Approved by asgerf
2 parents eaf68e8 + 4e0dfce commit d59ea3d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

javascript/ql/src/semmle/javascript/NodeJS.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,11 @@ private predicate moduleInFile(Module m, File f) { m.getFile() = f }
162162
* ```
163163
*/
164164
class Require extends CallExpr, Import {
165+
cached
165166
Require() {
166-
exists(RequireVariable req |
167-
this.getCallee() = req.getAnAccess() and
168-
// `mjs` files explicitly disallow `require`
169-
not getFile().getExtension() = "mjs"
170-
)
167+
any(RequireVariable req).getAnAccess() = getCallee() and
168+
// `mjs` files explicitly disallow `require`
169+
not getFile().getExtension() = "mjs"
171170
}
172171

173172
override PathExpr getImportedPath() { result = getArgument(0) }

0 commit comments

Comments
 (0)