C#: Run dotnet exec command silently.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -133,10 +133,9 @@ public DependencyManager(string srcDir, IDependencyOptions options, ILogger logg
             }
 
             var views = GetFiles("*.cshtml")
-                .Concat(GetFiles("*.razor"))
-                .ToArray();
+                .Concat(GetFiles("*.razor"));
 
-            if (views.Length > 0)
+            if (views.Any())
             {
                 // TODO: use SDK specified in global.json
                 // TODO: add feature flag to control razor generation

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs

@@ -34,20 +34,35 @@ private void Info()
             }
         }
 
-        private bool RunCommand(string args)
+        private static ProcessStartInfo MakeDotnetStartInfo(string args) =>
+            new ProcessStartInfo(dotnet, args)
+            {
+                UseShellExecute = false,
+                RedirectStandardOutput = true
+            };
+
+        private bool RunCommandAux(string args, bool silent)
         {
             progressMonitor.RunningProcess($"{dotnet} {args}");
-            using var proc = Process.Start(dotnet, args);
-            proc.WaitForExit();
-            if (proc.ExitCode != 0)
+            using var proc = silent
+                ? Process.Start(MakeDotnetStartInfo(args))
+                : Process.Start(dotnet, args);
+            proc?.WaitForExit();
+            var exitCode = proc?.ExitCode ?? -1;
+            if (exitCode != 0)
             {
-                progressMonitor.CommandFailed(dotnet, args, proc.ExitCode);
+                progressMonitor.CommandFailed(dotnet, args, exitCode);
                 return false;
             }
-
             return true;
         }
 
+        private bool RunCommand(string args) =>
+            RunCommandAux(args, false);
+
+        private bool RunCommandSilently(string args) =>
+            RunCommandAux(args, true);
+
         public bool RestoreToDirectory(string projectOrSolutionFile, string packageDirectory, string? pathToNugetConfig = null)
         {
             var args = $"restore --no-dependencies \"{projectOrSolutionFile}\" --packages \"{packageDirectory}\" /p:DisableImplicitNuGetFallbackFolder=true";
@@ -75,11 +90,7 @@ public bool AddPackage(string folder, string package)
         private IList<string> GetListed(string args, string artifact)
         {
             progressMonitor.RunningProcess($"{dotnet} {args}");
-            var pi = new ProcessStartInfo(dotnet, args)
-            {
-                RedirectStandardOutput = true,
-                UseShellExecute = false
-            };
+            var pi = MakeDotnetStartInfo(args);
             var exitCode = pi.ReadOutput(out var artifacts);
             if (exitCode != 0)
             {
@@ -92,9 +103,8 @@ private IList<string> GetListed(string args, string artifact)
 
         public bool Exec(string execArgs)
         {
-            // TODO: we might need to swallow the stdout of the started process to not pollute the logs of the extraction.
             var args = $"exec {execArgs}";
-            return RunCommand(args);
+            return RunCommandSilently(args);
         }
     }
 }