Crypto: Updating weak hash tests

Author: bdrodes

java/ql/test/experimental/query-tests/quantum/examples/WeakOrUnknownHash/WeakHash.expected

@@ -1,9 +1,4 @@
-#select
 | WeakHashing.java:15:55:15:83 | HashAlgorithm | Use of unapproved hash algorithm or API: MD5. |
 | WeakHashing.java:18:56:18:95 | HashAlgorithm | Use of unapproved hash algorithm or API: MD5. |
 | WeakHashing.java:21:86:21:90 | HashAlgorithm | Use of unapproved hash algorithm or API: MD5. |
 | WeakHashing.java:24:56:24:62 | HashAlgorithm | Use of unapproved hash algorithm or API: SHA1. |
-| WeakHashing.java:34:56:34:96 | HashAlgorithm | Use of unapproved hash algorithm or API: MD5. |
-testFailures
-| WeakHashing.java:27:125:27:133 | // $Alert | Missing result: Alert |
-| WeakHashing.java:40:111:40:119 | // $Alert | Missing result: Alert |

java/ql/test/experimental/query-tests/quantum/examples/WeakOrUnknownHash/WeakHashing.java

@@ -30,8 +30,9 @@ void hashing() throws NoSuchAlgorithmException, IOException {
 
         props2.load(new FileInputStream("unobserved-file.properties"));
 
-        // BAD: "hashalg1" is not visible in the file loaded for props2
-        MessageDigest bad6 = MessageDigest.getInstance(props2.getProperty("hashAlg1", "SHA-256")); // $Alert[java/quantum/weak-hash]
+        // BAD: "hashAlg2" is not visible in the file loaded for props2, should be an unknown 
+        // FALSE NEGATIVE for unknown hash
+        MessageDigest bad6 = MessageDigest.getInstance(props2.getProperty("hashAlg2", "SHA-256")); // $Alert[java/quantum/unknown-hash]
 
         // GOOD: Using a strong hashing algorithm
         MessageDigest ok = MessageDigest.getInstance(props.getProperty("hashAlg2"));