JS: Preserve reflective calls in getAMethodCall

asgerf · asgerf · commit cafdcfa4de32 · 2020-04-23T13:57:14.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Sources.qll b/javascript/ql/src/semmle/javascript/dataflow/Sources.qll
@@ -245,7 +245,7 @@ private module Cached {
    */
   cached
   predicate isSyntacticMethodCall(DataFlow::CallNode call) {
-    call.asExpr().(CallExpr).getCallee().getUnderlyingReference() instanceof PropAccess
+    call.getCalleeNode().asExpr().getUnderlyingReference() instanceof PropAccess
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ private module Cached {`
`245`	`245`	`*/`
`246`	`246`	`cached`
`247`	`247`	`predicate isSyntacticMethodCall(DataFlow::CallNode call) {`
`248`		`- call.asExpr().(CallExpr).getCallee().getUnderlyingReference() instanceof PropAccess`
	`248`	`+ call.getCalleeNode().asExpr().getUnderlyingReference() instanceof PropAccess`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`