Skip to content

Commit c885490

Browse files
author
Esben Sparre Andreasen
committed
JS: address review comments
1 parent 6b8fd49 commit c885490

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ module NodeJSLib {
379379
*
380380
* We determine this by looking for an externs declaration for
381381
* `fs.methodName` where the `i`th parameter's name is `data` or
382-
* `buffer` or a 'callback'.
382+
* `buffer` or a `callback`.
383383
*/
384384
private predicate fsDataParam(string methodName, int i, string n) {
385385
exists (ExternalMemberDecl decl, Function f, JSDocParamTag p |

javascript/ql/src/semmle/javascript/security/dataflow/FileAccessToHttp.qll

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,8 @@ module FileAccessToHttp {
4242
node instanceof Sanitizer
4343
}
4444

45-
/** additional taint step that taints an object wrapping a source */
4645
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
47-
(
48-
pred = DataFlow::valueNode(_) or
49-
pred = DataFlow::parameterNode(_) or
50-
pred instanceof DataFlow::PropRead
51-
) and
46+
// taint entire object on property write
5247
exists (DataFlow::PropWrite pwr |
5348
succ = pwr.getBase() and
5449
pred = pwr.getRhs()

0 commit comments

Comments
 (0)