Improve AliasType.getUnderlyingType

owen-mc · mbg · commit c7a5f3357f1f · 2024-08-29T12:45:41.000+01:00
Read through as many aliases as possible before getting
the underlying type.
diff --git a/go/ql/lib/semmle/go/Types.qll b/go/ql/lib/semmle/go/Types.qll
@@ -1012,7 +1012,7 @@ class AliasType extends @typealias, CompositeType {
   /** Gets the aliased type (i.e. that appears on the RHS of the alias definition). */
   Type getRhs() { alias_rhs(this, result) }
 
-  override Type getUnderlyingType() { result = this.getRhs().getUnderlyingType() }
+  override Type getUnderlyingType() { result = unalias(this).getUnderlyingType() }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -1012,7 +1012,7 @@ class AliasType extends @typealias, CompositeType {`
`1012`	`1012`	`/** Gets the aliased type (i.e. that appears on the RHS of the alias definition). */`
`1013`	`1013`	`Type getRhs() { alias_rhs(this, result) }`
`1014`	`1014`
`1015`		`- override Type getUnderlyingType() { result = this.getRhs().getUnderlyingType() }`
	`1015`	`+ override Type getUnderlyingType() { result = unalias(this).getUnderlyingType() }`
`1016`	`1016`	`}`
`1017`	`1017`
`1018`	`1018`	`/**`