Java: Fix missing jump step from PostUpdate to capture.

aschackmull · aschackmull · commit c78906500dc3 · 2020-03-23T10:24:25.000+01:00
diff --git a/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll b/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
@@ -113,7 +113,8 @@ private predicate variableCaptureStep(Node node1, ExprNode node2) {
  */
 predicate jumpStep(Node node1, Node node2) {
   staticFieldStep(node1, node2) or
-  variableCaptureStep(node1, node2)
+  variableCaptureStep(node1, node2) or
+  variableCaptureStep(node1.(PostUpdateNode).getPreUpdateNode(), node2)
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,8 @@ private predicate variableCaptureStep(Node node1, ExprNode node2) {`
`113`	`113`	`*/`
`114`	`114`	`predicate jumpStep(Node node1, Node node2) {`
`115`	`115`	`staticFieldStep(node1, node2) or`
`116`		`- variableCaptureStep(node1, node2)`
	`116`	`+ variableCaptureStep(node1, node2) or`
	`117`	`+ variableCaptureStep(node1.(PostUpdateNode).getPreUpdateNode(), node2)`
`117`	`118`	`}`
`118`	`119`
`119`	`120`	`/**`