Skip to content

Commit c6fb303

Browse files
maikypediageoffw0
andauthored
Suggested changes
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
1 parent 9ce75da commit c6fb303

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

swift/ql/src/experimental/Security/CWE-022/UnsafeUnpack.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ The following examples unpacks a remote zip using `fileManager.unzipItem()` whic
3131

3232

3333
<p>Consider using a safer module, such as: <code>ZIPArchive</code></p>
34-
<sample src="ZIPArchiveGood.swift" />
34+
<sample src="ZipArchiveGood.swift" />
3535
</example>
3636

3737
<references>

swift/ql/src/experimental/Security/CWE-022/UnsafeUnpack.ql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/**
22
* @name Arbitrary file write during a zip extraction from a user controlled source
3-
* @description Unpacking user controlled zips without validating if destination path file
4-
* is within the destination directory can cause files outside
5-
* the destination directory to be overwritten.
3+
* @description Unpacking user controlled zips without validating whether the
4+
* destination file path is within the destination directory can cause files
5+
* outside the destination directory to be overwritten.
66
* @kind path-problem
77
* @problem.severity error
8-
* @security-severity 9.8
8+
* @security-severity 7.5
99
* @precision high
1010
* @id swift/unsafe-unpacking
1111
* @tags security

0 commit comments

Comments
 (0)