ignore when the reciever is the empty array

erik-krogh · erik-krogh · commit c6f53199d400 · 2019-10-27T00:24:38.000+02:00
diff --git a/javascript/ql/src/Statements/IgnoreArrayResult.ql b/javascript/ql/src/Statements/IgnoreArrayResult.ql
@@ -41,5 +41,7 @@ predicate isIgnoredPureArrayCall(DataFlow::MethodCallNode call) {
 }
 
 from DataFlow::MethodCallNode call
-where callsArray(call) instanceof DataFlow::ArrayCreationNode
+where 
+  callsArray(call) instanceof DataFlow::ArrayCreationNode and
+  not call.getReceiver().asExpr().(ArrayExpr).getSize() = 0
 select call, "Result from call to " + call.getMethodName() + " ignored."

Original file line number	Diff line number	Diff line change
`@@ -41,5 +41,7 @@ predicate isIgnoredPureArrayCall(DataFlow::MethodCallNode call) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`from DataFlow::MethodCallNode call`
`44`		`-where callsArray(call) instanceof DataFlow::ArrayCreationNode`
	`44`	`+where`
	`45`	`+ callsArray(call) instanceof DataFlow::ArrayCreationNode and`
	`46`	`+ not call.getReceiver().asExpr().(ArrayExpr).getSize() = 0`
`45`	`47`	`select call, "Result from call to " + call.getMethodName() + " ignored."`