ruby: fix bad join

Author: yoff

ruby/ql/src/queries/variables/UninitializedLocal.ql

@@ -51,6 +51,12 @@ Expr evaluatingMention(LocalVariableReadAccess read) {
   result.(NotExpr).getOperand() = read
 }
 
+predicate loopProtects(ConditionalLoop l, LocalVariableReadAccess read) {
+  l.getCondition() = read.getVariable().getAnAccess() and
+  l.entersLoopWhenConditionIs(false) and
+  l.getAControlFlowNode().getBasicBlock().dominates(read.getAControlFlowNode().getBasicBlock())
+}
+
 class RelevantLocalVariableReadAccess extends LocalVariableReadAccess {
   RelevantLocalVariableReadAccess() {
     not exists(MethodCall c |
@@ -76,11 +82,7 @@ class RelevantLocalVariableReadAccess extends LocalVariableReadAccess {
     not exists(ConditionalExpr c | factor(c.getCondition(), this.getVariable().getAnAccess()) |
       this = c.getBranch(true).getAChild*()
     ) and
-    not exists(ConditionalLoop l |
-      l.getCondition() = this.getVariable().getAnAccess() and
-      l.entersLoopWhenConditionIs(false) and
-      l.getAControlFlowNode().getBasicBlock().dominates(this.getAControlFlowNode().getBasicBlock())
-    )
+    not exists(ConditionalLoop l | loopProtects(l, this))
   }
 }