C++: Refine nodeIsBarrierIn using getNodeForSource.

geoffw0 · geoffw0 · commit c641a316408f · 2020-02-24T14:39:31.000Z
diff --git a/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll b/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
@@ -161,7 +161,7 @@ private predicate nodeIsBarrier(DataFlow::Node node) {
 
 private predicate nodeIsBarrierIn(DataFlow::Node node) {
   // don't use dataflow into taint sources, as this leads to duplicate results.
-  isUserInput(node.asExpr(), _)
+  node = getNodeForSource(any(Expr e))
 }
 
 private predicate instructionTaintStep(Instruction i1, Instruction i2) {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ private predicate nodeIsBarrier(DataFlow::Node node) {`
`161`	`161`
`162`	`162`	`private predicate nodeIsBarrierIn(DataFlow::Node node) {`
`163`	`163`	`// don't use dataflow into taint sources, as this leads to duplicate results.`
`164`		`- isUserInput(node.asExpr(), _)`
	`164`	`+ node = getNodeForSource(any(Expr e))`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`private predicate instructionTaintStep(Instruction i1, Instruction i2) {`