C++: Better caching for getPrimaryInstructionForSideEffect()

Dave Bartolomeo · Dave Bartolomeo · commit c511cc3444c5 · 2020-06-08T15:37:36.000-04:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRConstruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRConstruction.qll
@@ -392,7 +392,7 @@ private module Cached {
   }
 
   cached
-  Instruction getPrimaryInstructionForSideEffect(Instruction instruction) {
+  Instruction getPrimaryInstructionForSideEffect(SideEffectInstruction instruction) {
     exists(TranslatedElement element, InstructionTag tag |
       instructionOrigin(instruction, element, tag) and
       result = element.getPrimaryInstructionForSideEffect(tag)

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ private module Cached {`
`392`	`392`	`}`
`393`	`393`
`394`	`394`	`cached`
`395`		`- Instruction getPrimaryInstructionForSideEffect(Instruction instruction) {`
	`395`	`+ Instruction getPrimaryInstructionForSideEffect(SideEffectInstruction instruction) {`
`396`	`396`	`exists(TranslatedElement element, InstructionTag tag \|`
`397`	`397`	`instructionOrigin(instruction, element, tag) and`
`398`	`398`	`result = element.getPrimaryInstructionForSideEffect(tag)`