rename getExceptionalNode to getExceptionTarget

Author: erik-krogh

javascript/ql/src/semmle/javascript/Expr.qll

@@ -250,7 +250,7 @@ class Expr extends @expr, ExprOrStmt, ExprOrType, AST::ValueNode {
    * Gets the data-flow node where exceptions thrown by this expression will
    * propagate if this expression causes an exception to be thrown.
    */
-  DataFlow::Node getExceptionalNode() {
+  DataFlow::Node getExceptionTarget() {
     if exists(this.getEnclosingStmt().getEnclosingTryCatchStmt())
     then
       result = DataFlow::parameterNode(this

javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll

@@ -66,7 +66,8 @@ predicate localExceptionStep(DataFlow::Node pred, DataFlow::Node succ) {
     or
     DataFlow::exceptionalInvocationReturnNode(pred, expr)
   |
-    succ = expr.getExceptionalNode()
+    succ = expr.getExceptionTarget
+()
   )
 }
 

javascript/ql/src/semmle/javascript/security/dataflow/ExceptionXss.qll

@@ -73,7 +73,7 @@ module ExceptionXss {
       DataFlow::FlowLabel outlbl
     ) {
       inlbl instanceof NotYetThrown and (outlbl.isTaint() or outlbl instanceof NotYetThrown) and
-      succ = pred.asExpr().getExceptionalNode() and
+      succ = pred.asExpr().getExceptionTarget() and
       canThrowSensitiveInformation(pred)
       or
       // All the usual taint-flow steps apply on data-flow before it has been thrown in an exception.