Skip to content

Commit c181b92

Browse files
committed
JS: Fix some mistranslated OK-style comments
1 parent eccbcf9 commit c181b92

File tree

1 file changed

+4
-4
lines changed
  • javascript/ql/test/query-tests/Security/CWE-915/PrototypePollutingFunction

1 file changed

+4
-4
lines changed

javascript/ql/test/query-tests/Security/CWE-915/PrototypePollutingFunction/tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ function mergePlainObjectsOnly(target, source) {
354354
if (isNonArrayObject(source[key]) && key in target) {
355355
target[key] = mergePlainObjectsOnly(target[key], source[key], options);
356356
} else {
357-
target[key] = source[key]; // $ Alert - OK - but flagged anyway due to imprecise barrier for captured variable
357+
target[key] = source[key]; // $ SPURIOUS: Alert - due to imprecise barrier for captured variable
358358
}
359359
});
360360
}
@@ -390,7 +390,7 @@ function mergeUsingCallback(dst, src) {
390390
if (dst[key]) {
391391
mergeUsingCallback(dst[key], src[key]);
392392
} else {
393-
dst[key] = src[key]; // but not currently flagged
393+
dst[key] = src[key]; // $ MISSING: Alert
394394
}
395395
});
396396
}
@@ -486,7 +486,7 @@ function copyPlainObject(dst, src) {
486486
if (dst[key] && isPlainObject(src)) {
487487
copyPlainObject(dst[key], src[key]);
488488
} else {
489-
dst[key] = src[key]; // $ Alert - OK - but flagged anyway
489+
dst[key] = src[key]; // $ SPURIOUS: Alert
490490
}
491491
}
492492
}
@@ -602,7 +602,7 @@ function merge_captureBarrier(dest, source) {
602602
if (dest[key]) {
603603
merge_captureBarrier(dest[key], source[key]);
604604
} else {
605-
dest[key] = captureBarrier(source[key]); // $ Alert - OK - but currently flagged anyway
605+
dest[key] = captureBarrier(source[key]); // $ SPURIOUS: Alert
606606
}
607607
}
608608
}

0 commit comments

Comments
 (0)