Python: Address review comments

Author: tausbn

python/ql/lib/semmle/python/Function.qll

@@ -165,12 +165,18 @@ class Function extends Function_, Scope, AstNode {
   }
 
   /** Gets the minimum number of positional arguments that can be correctly passed to this function. */
-  int getMinArguments() {
+  int getMinPositionalArguments() {
     result = count(this.getAnArg()) - count(this.getDefinition().getArgs().getADefault())
   }
 
-  /** Gets the maximum number of positional arguments that can be correctly passed to this function. */
-  int getMaxArguments() {
+  /**
+   * Gets the maximum number of positional arguments that can be correctly passed to this function.
+   *
+   * If the function has a `*vararg` parameter, there is no upper limit on the number of positional
+   * arguments that can be passed to the function. In this case, this method returns a very large
+   * number (currently `INT_MAX`, 2147483647, but this may change in the future).
+   */
+  int getMaxPositionalArguments() {
     if exists(this.getVararg())
     then result = 2147483647 // INT_MAX
     else result = count(this.getAnArg())

python/ql/lib/semmle/python/objects/ObjectAPI.qll

@@ -738,9 +738,9 @@ class PythonFunctionValue extends FunctionValue {
     else result = "function " + this.getQualifiedName()
   }
 
-  override int minParameters() { result = this.getScope().getMinArguments() }
+  override int minParameters() { result = this.getScope().getMinPositionalArguments() }
 
-  override int maxParameters() { result = this.getScope().getMaxArguments() }
+  override int maxParameters() { result = this.getScope().getMaxPositionalArguments() }
 
   /** Gets a control flow node corresponding to a return statement in this function */
   ControlFlowNode getAReturnedNode() { result = this.getScope().getAReturnValueFlowNode() }